From 98b55a89ee02d3f48c387191cae03908f763d0aa Mon Sep 17 00:00:00 2001 From: Eli Barzilay Date: Thu, 12 Nov 2009 00:18:08 +0000 Subject: [PATCH] comments svn: r16704 original commit: e34e001167077490a27fd9a1cd1ed5209c24d65c --- collects/unstable/mutated-vars.ss | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/collects/unstable/mutated-vars.ss b/collects/unstable/mutated-vars.ss index 1e141c54..efa9b39e 100644 --- a/collects/unstable/mutated-vars.ss +++ b/collects/unstable/mutated-vars.ss @@ -42,5 +42,14 @@ ;; is-var-mutated? : identifier -> boolean (define (is-var-mutated? id) (module-identifier-mapping-get table id (lambda _ #f))) -(provide find-mutated-vars is-var-mutated?) +;; Eli: +;; - The `for-template' doesn't look like it's needed. +;; - This is the *worst* looking interface I've seen in a while. Seems very +;; specific to some unclear optimization needs. (Either that, or translated +;; from C.) +;; - Besides weird, identifiers maps are (IIRC) not weak, which makes this even +;; less general. +;; - What's with the typed-scheme literals? If they were needed, then +;; typed-scheme is probably broken now. +(provide find-mutated-vars is-var-mutated?)