suzanne.soy/typed-racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make these definitions safe again.

Browse Source 
As of this moment, the performance win on new-metrics.rkt for
using the unsafe version is about 1% (avg over 10 runs), which
isn't enough to make it worth the segfaults. I believe that
changes to the JIT since 2012 (when the unsafe ops were added)
have sped up struct access.
This commit is contained in:
Sam Tobin-Hochstadt 2015-11-02 09:20:23 -05:00
parent cb35383143
commit ad0c69ea29
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
typed-racket-lib/typed-racket/rep/rep-utils.rkt
View File

@ -362,8 +362,8 @@
[PathElem def-pathelem #:PathElem pathelem-case print-pathelem pathelem-name-ht pathelem-rec-id])
;; NOTE: change these if the definitions above change, or everything will segfault
(define-syntax-rule (unsafe-Rep-seq v) (unsafe-struct*-ref v 0))
(define-syntax-rule (unsafe-Type-key v) (unsafe-struct*-ref v 4))
(define-syntax-rule (unsafe-Rep-seq v) (Rep-seq v))
(define-syntax-rule (unsafe-Type-key v) (Type-key v))
(provide unsafe-Rep-seq unsafe-Type-key)
(define (Rep-values rep)