Change prop:equal+hash to use Integer #1

2019-11-06T03:33:11Z

AlexKnauth commented

2019-11-06 03:33:11 +00:00

(Migrated from github.com)

The prop:equal+hash property allows Integer the result type of the hashing functions. This PR changes the types to use Integer instead of Fixnum.

This is still well-typed with equal-hash-code because when a prop:equal+hash function returns an integer that isn't a fixnum, equal-hash-code will still return a fixnum.

The `prop:equal+hash` property allows `Integer` the result type of the hashing functions. This PR changes the types to use `Integer` instead of `Fixnum`. This is still well-typed with `equal-hash-code` because when a `prop:equal+hash` function returns an integer that isn't a fixnum, `equal-hash-code` will still return a fixnum.

codecov-io commented

2019-11-06 03:49:52 +00:00

(Migrated from github.com)

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files          15       15           
  Lines         605      605           
=======================================
  Hits          557      557           
  Misses         48       48

Impacted Files	Coverage Δ
main.rkt	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 416c112...df52749. Read the comment docs.

# [Codecov](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1?src=pr&el=h1) Report > Merging [#1](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1?src=pr&el=desc) into [master](https://codecov.io/gh/jsmaniac/typed-struct-props/commit/416c1123a7043eaf08e803cf91317b49f030fc18?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1/graphs/tree.svg?width=650&token=9Px4EB6Kgk&height=150&src=pr)](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1 +/- ## ======================================= Coverage 92.06% 92.06% ======================================= Files 15 15 Lines 605 605 ======================================= Hits 557 557 Misses 48 48 ``` | [Impacted Files](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [main.rkt](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1/diff?src=pr&el=tree#diff-bWFpbi5ya3Q=) | `100% <100%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1?src=pr&el=footer). Last update [416c112...df52749](https://codecov.io/gh/jsmaniac/typed-struct-props/pull/1?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

SuzanneSoy commented

2019-11-11 22:46:51 +00:00

(Migrated from github.com)

Merged, thanks!

Sign in to join this conversation.

No reviewers