mvr initialization should now optimize away the common case

js-assembler/assemble-helpers.rkt

@@ -298,18 +298,24 @@
 
 (: assemble-label (Label Blockht -> String))
 (define (assemble-label a-label Blockht)
-  (let ([chunks
+  (define a-block (hash-ref Blockht (Label-name a-label)))
-         (regexp-split #rx"[^a-zA-Z0-9]+"
+  (cond
-                       (symbol->string (Label-name a-label)))])
+   [(block-looks-like-context-expected-values? a-block)
+    => (lambda (expected)
+         (format "RT.si_context_expected(~a)" expected))]
+   [else
+    (define chunks
+      (regexp-split #rx"[^a-zA-Z0-9]+"
+                    (symbol->string (Label-name a-label))))
     (cond
-      [(empty? chunks)
+     [(empty? chunks)
-       (error "impossible: empty label ~s" a-label)]
+      (error "impossible: empty label ~s" a-label)]
-      [(empty? (rest chunks))
+     [(empty? (rest chunks))
-       (string-append "_" (first chunks))]
+      (string-append "_" (first chunks))]
-      [else
+     [else
-       (string-append "_"
+      (string-append "_"
-                      (first chunks)
+                     (first chunks)
-                      (apply string-append (map string-titlecase (rest chunks))))])))
+                     (apply string-append (map string-titlecase (rest chunks))))])]))
 
 
 

js-assembler/assemble.rkt

@@ -139,10 +139,23 @@ EOF
          [(symbol? stmt)
           (next)]
          [(LinkedLabel? stmt)
-          ;; Setting up multiple-value-return
+          ;; Setting up multiple-value-return.
-          (fprintf op "~a.mvr=~a;\n" 
+          ;; Optimization: in the most common case (expecting only one), we optimize away
-                   (assemble-label (make-Label (LinkedLabel-label stmt)) blockht)
+          ;; the assignment, because there's a distinguished instruction, and it's implied
-                   (assemble-label (make-Label (LinkedLabel-linked-to stmt)) blockht))
+          ;; that if .mvr is missing, that the block only expects one.
+          (define linked-to-block (hash-ref blockht (LinkedLabel-linked-to stmt)))
+          (cond
+           [(block-looks-like-context-expected-values? linked-to-block)
+            => (lambda (expected)
+                 (cond
+                  [(= expected 1)
+                   (void)]
+                  [else
+                   (fprintf op "~a.mvr=RT.si_context_expected(~a);\n" expected)]))]
+           [else
+            (fprintf op "~a.mvr=~a;\n" 
+                     (assemble-label (make-Label (LinkedLabel-label stmt)) blockht)
+                     (assemble-label (make-Label (LinkedLabel-linked-to stmt)) blockht))])
           (next)]
          [(DebugPrint? stmt)
           (next)]

js-assembler/runtime-src/baselib-functions.js

@@ -72,12 +72,12 @@
             return MACHINE.c.pop().label(MACHINE);
         } else if (returnArgs.length === 0) {
             MACHINE.a = 0;
-            return MACHINE.c.pop().label.mvr(MACHINE);
+            return (MACHINE.c.pop().label.mvr || plt.runtime.si_context_expected_1)(MACHINE);
         } else {
             MACHINE.a = returnArgs.length;
             MACHINE.v = returnArgs.shift();
             MACHINE.e.push.apply(MACHINE.e, returnArgs.reverse());
-            return MACHINE.c.pop().label.mvr(MACHINE);
+            return (MACHINE.c.pop().label.mvr || plt.runtime.si_context_expected_1)(MACHINE);
         }
     };
 

js-assembler/runtime-src/runtime.js

@@ -817,6 +817,7 @@
     exports['getTracedCalleeKey'] = getTracedCalleeKey;
 
     exports['si_context_expected'] = si_context_expected;
+    exports['si_context_expected_1'] = si_context_expected_1;
     exports['checkClosureAndArity'] = checkClosureAndArity;