fixed isList so it checks for cycles

js-assembler/runtime-src/baselib-lists.js

@@ -172,7 +172,7 @@
 
 
     // Coerse a list back into a JavaScript array.
-    var listToArray = function(lst) {
+    var listToArray = function (lst) {
         var result = [];
         while (lst !== EMPTY) {
             result.push(lst.first);
@@ -185,12 +185,15 @@
     // isList: Any -> Boolean
     // Returns true if x is a list (a chain of pairs terminated by EMPTY).
     var isList = function (x) { 
-        while (x !== EMPTY) {
-            if (x instanceof Cons) {
-                x = x.rest;
-            } else {
-                return false;
-            }
+        var tortoise, hare;
+        tortoise = hare = x;
+        while (true) {
+            if (tortoise instanceof Cons) { tortoise = tortoise.rest; }
+            if (hare instanceof Cons) { hare = hare.rest; }
+            if (hare instanceof Cons) { hare = hare.rest; }
+            if (hare === EMPTY) { return true; }
+            if (tortoise === hare) { return false; }
+            if ((hare instanceof Cons) === false) { return false; }
         }
         return true;
     };

tests/more-tests/lists.expected

@@ -2,6 +2,10 @@
 ("hello" "world")
 true
 true
+true
+false
+true
+true
 false
 true
 hello

tests/more-tests/lists.rkt

@@ -3,6 +3,11 @@
 '(1 2 3)
 (list "hello" "world")
 
+(list? empty)
+(list? '(1))
+(list? '(1 2))
+(list? 1)
+
 (empty? empty)
 (empty? '())
 (cons? '())

tests/more-tests/sharing.expected

@@ -22,3 +22,5 @@ jill
 jane
 
 
+true
+false

tests/more-tests/sharing.rkt

@@ -70,4 +70,12 @@
   (for-each displayln (map person-name (person-friends b)))
   (newline)
   (for-each displayln (map person-name (person-friends c)))
-  (newline))
+  (newline))
+
+
+
+;; Make sure cyclic lists are treated correctly by list?
+(shared ([a (cons 1 a)])
+  (begin
+    (displayln (pair? a))
+    (displayln (list? a))))