suzanne.soy/whalesong
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

eliminating unnecessary argcount assignment when primitives are used

Browse Source
This commit is contained in:
Danny Yoo 2012-02-29 14:20:14 -05:00
parent 2ade0f2db6
commit aed845f3f5
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
compiler/compiler.rkt
View File

@ -1099,17 +1099,26 @@
(append-instruction-sequences (append-instruction-sequences
(make-PushEnvironment (length (App-operands exp)) #f) (make-PushEnvironment (length (App-operands exp)) #f)
(apply append-instruction-sequences operand-codes) (apply append-instruction-sequences operand-codes)
(make-AssignImmediate 'argcount (make-Const (length (App-operands exp))))
;; Optimization: if the expected arity is a known constant, we don't
;; need to touch argcount either. If it's variable, we emit the argcount, since
;; it's something we need at runtime.
(if (number? expected-arity)
empty-instruction-sequence
(make-AssignImmediate 'argcount (make-Const (length (App-operands exp)))))
(if (arity-matches? expected-arity (length (App-operands exp))) (if (arity-matches? expected-arity (length (App-operands exp)))
(compile-primitive-procedure-call primitive-name (compile-primitive-procedure-call primitive-name
cenv cenv
(make-Const (length (App-operands exp))) (make-Const (length (App-operands exp)))
target target
linkage) linkage)
(append-instruction-sequences
(compile (App-operator exp) extended-cenv 'proc next-linkage/expects-single)
(make-Perform (make-RaiseArityMismatchError! (make-Perform (make-RaiseArityMismatchError!
(make-Reg 'proc) (make-Reg 'proc)
expected-arity expected-arity
(make-Const (length (App-operands exp))))))))) (make-Const (length (App-operands exp))))))))))
;; If we know the procedure is implemented as a primitive (as opposed to a general closure), ;; If we know the procedure is implemented as a primitive (as opposed to a general closure),
@ -1117,7 +1126,7 @@
;; We don't need to check arity (as that's already been checked statically). ;; We don't need to check arity (as that's already been checked statically).
;; Assumes 1. the procedure value is NOT loaded into proc. We know statically what the ;; Assumes 1. the procedure value is NOT loaded into proc. We know statically what the
;; procedure is supposed to be. ;; procedure is supposed to be.
;; 2. number-of-arguments has been written into the argcount register, ;; 2. (OPTIONAL) number-of-arguments has been conditionally written into the argcount register,
; ; 3. the number-of-arguments values are on the stack. ; ; 3. the number-of-arguments values are on the stack.
(: compile-primitive-procedure-call (Symbol CompileTimeEnvironment OpArg Target Linkage -> InstructionSequence)) (: compile-primitive-procedure-call (Symbol CompileTimeEnvironment OpArg Target Linkage -> InstructionSequence))
(define (compile-primitive-procedure-call primitive-name cenv number-of-arguments target linkage) (define (compile-primitive-procedure-call primitive-name cenv number-of-arguments target linkage)

2
version.rkt
View File

@ -7,4 +7,4 @@
(provide version) (provide version)
(: version String) (: version String)
(define version "1.201") (define version "1.202")