From 15108eea3f099a5a39a145ed55043d1ed9889e6a Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Sun, 20 Jul 2014 15:56:55 -0400 Subject: [PATCH] Fix intermittent source file deletion when dragging files in on Windows (at least, if this is caused by what I think it was caused by) https://forums.zotero.org/discussion/38486/ --- chrome/content/zotero/xpcom/itemTreeView.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/chrome/content/zotero/xpcom/itemTreeView.js b/chrome/content/zotero/xpcom/itemTreeView.js index 7f7b3faf7..6b0c8de16 100644 --- a/chrome/content/zotero/xpcom/itemTreeView.js +++ b/chrome/content/zotero/xpcom/itemTreeView.js @@ -2896,7 +2896,7 @@ Zotero.ItemTreeView.prototype.canDropCheck = function (row, orient, dataTransfer var itemGroup = this._itemGroup; - if (orient == 0) { + if (row != -1 && orient == 0) { var rowItem = this._getItemAtRow(row).ref; // the item we are dragging over } @@ -2904,7 +2904,7 @@ Zotero.ItemTreeView.prototype.canDropCheck = function (row, orient, dataTransfer var items = Zotero.Items.get(ids); // Directly on a row - if (orient == 0) { + if (rowItem) { var canDrop = false; for each(var item in items) { @@ -2981,7 +2981,7 @@ Zotero.ItemTreeView.prototype.canDropCheck = function (row, orient, dataTransfer } else if (dataType == "text/x-moz-url" || dataType == 'application/x-moz-file') { // Disallow direct drop on a non-regular item (e.g. note) - if (orient == 0) { + if (rowItem) { if (!rowItem.isRegularItem()) { return false; }