suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fall back to en-US sorting if we can't parse the locale

Browse Source
This commit is contained in:
Dan Stillman 2017-10-26 00:54:05 -04:00
parent 56289b6693
commit 1deba232fa
1 changed files with 25 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
chrome/content/zotero/xpcom/zotero.js
View File

@ -1536,7 +1536,12 @@ Services.scriptloader.loadSubScript("resource://zotero/polyfill.js");
} }
// Extract a valid language tag // Extract a valid language tag
locale = locale.match(/^[a-z]{2}(\-[A-Z]{2})?/)[0]; try {
locale = locale.match(/^[a-z]{2}(\-[A-Z]{2})?/)[0];
}
catch (e) {
throw new Error(`Error parsing locale ${locale}`);
}
locales = [locale]; locales = [locale];
} }
@ -1549,12 +1554,25 @@ Services.scriptloader.loadSubScript("resource://zotero/polyfill.js");
catch (e) { catch (e) {
Zotero.logError(e); Zotero.logError(e);
// If there's an error, just skip sorting // Fall back to en-US sorting
collator = { try {
compare: function (a, b) { Zotero.logError("Falling back to en-US sorting");
return 0; collator = new Intl.Collator(['en-US'], {
} ignorePunctuation: true,
}; numeric: true,
sensitivity: 'base'
});
}
catch (e) {
Zotero.logError(e);
// If there's still an error, just skip sorting
collator = {
compare: function (a, b) {
return 0;
}
};
}
} }
// Grab all ASCII punctuation and space at the begining of string // Grab all ASCII punctuation and space at the begining of string