From 2480b04f10d4cc05d4ff84b6bf396cc1768d2f65 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Tue, 7 Apr 2009 01:10:03 +0000 Subject: [PATCH] Fix globally scoped variable and change match(...).join("") to match(...)[0] --- translators/NCBI PubMed.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/translators/NCBI PubMed.js b/translators/NCBI PubMed.js index f24f2d4e9..5c8724870 100644 --- a/translators/NCBI PubMed.js +++ b/translators/NCBI PubMed.js @@ -86,13 +86,13 @@ function lookupPMIDs(ids, doc) { if (article.Pagination.MedlinePgn.length()){ var fullPageRange = article.Pagination.MedlinePgn.text().toString(); var pageRange = fullPageRange.match(/\d+-\d+/g); - for (i in pageRange) { - var pageRangeStart = pageRange[i].match(/^\d+/).join(""); - var pageRangeEnd = pageRange[i].match(/\d+$/).join(""); + for (var i in pageRange) { + var pageRangeStart = pageRange[i].match(/^\d+/)[0]; + var pageRangeEnd = pageRange[i].match(/\d+$/)[0]; if (pageRangeStart.length > pageRangeEnd.length) { pageRangeEnd = pageRangeStart.substring(0,pageRangeStart.length-pageRangeEnd.length) + pageRangeEnd; fullPageRange = fullPageRange.replace(pageRange[i],pageRangeStart+"-"+pageRangeEnd); - } + } } newItem.pages = fullPageRange; }