From 2588a0a651fdf434fdccbcd87146184e59c9dea5 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Wed, 3 May 2017 03:54:54 -0400 Subject: [PATCH] Simplify deleteCacheObjectVersions() query --- chrome/content/zotero/xpcom/sync/syncLocal.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/xpcom/sync/syncLocal.js b/chrome/content/zotero/xpcom/sync/syncLocal.js index 3b92afc65..068732263 100644 --- a/chrome/content/zotero/xpcom/sync/syncLocal.js +++ b/chrome/content/zotero/xpcom/sync/syncLocal.js @@ -1082,10 +1082,9 @@ Zotero.Sync.Data.Local = { * @param {Integer} [maxVersion] */ deleteCacheObjectVersions: function (objectType, libraryID, key, minVersion, maxVersion) { - var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? " - + "AND syncObjectTypeID IN (SELECT syncObjectTypeID FROM " - + "syncObjectTypes WHERE name=?)"; - var params = [libraryID, key, objectType]; + var syncObjectTypeID = Zotero.Sync.Data.Utilities.getSyncObjectTypeID(objectType); + var sql = "DELETE FROM syncCache WHERE libraryID=? AND key=? AND syncObjectTypeID=?"; + var params = [libraryID, key, syncObjectTypeID]; if (minVersion && minVersion == maxVersion) { sql += " AND version=?"; params.push(minVersion);