suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Temporary fix for child items added via context menu of parent in a collection being added to collectionItems -- don't include them in Zotero.Collection.getChildItems()

Browse Source
This commit is contained in:
Dan Stillman 2008-05-22 09:28:31 +00:00
parent da07a7e984
commit 2d4c555938
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
chrome/content/zotero/xpcom/data_access.js
View File

@ -3452,7 +3452,7 @@ Zotero.Collection.prototype.removeItems = function(itemIDs) {
/*
* Returns an array of child items of this collecetion as Zotero.Item instances,
* Returns an array of child items of this collection as Zotero.Item instances,
* or FALSE if none
*/
Zotero.Collection.prototype.getChildItems = function () {
@ -3561,8 +3561,14 @@ Zotero.Collection.prototype.toArray = function() {
Zotero.Collection.prototype._loadChildItems = function(){
this._childItems = new Zotero.Hash();
var sql = "SELECT itemID FROM collectionItems WHERE collectionID=" + this._id;
var itemIDs = Zotero.DB.columnQuery(sql);
var sql = "SELECT itemID FROM collectionItems WHERE collectionID=? "
// DEBUG: Fix for child items created via context menu on parent within
// a collection being added to the current collection
+ "AND itemID NOT IN "
+ "(SELECT itemID FROM itemNotes WHERE sourceItemID IS NOT NULL) "
+ "AND itemID NOT IN "
+ "(SELECT itemID FROM itemAttachments WHERE sourceItemID IS NOT NULL)";
var itemIDs = Zotero.DB.columnQuery(sql, this._id);
if (itemIDs){
for (var i=0; i<itemIDs.length; i++){