suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Convert between primary creator types when switching item types instead of reverting to "Contributor" if the current creator type isn't valid.

Browse Source
This commit is contained in:
Dan Stillman 2008-05-27 06:30:31 +00:00
parent 680c515e17
commit 2f2c8645cc
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
chrome/content/zotero/xpcom/data_access.js
View File

@ -248,9 +248,21 @@ Zotero.Item.prototype.setType = function(itemTypeID, loadIn) {
for (var i in creators){
if (!Zotero.CreatorTypes.isValidForItemType(creators[i].creatorTypeID, itemTypeID))
{
// Convert existing primary creator type to new item type's
// primary creator type, or contributor (creatorTypeID 2)
// if none or not currently primary
var oldPrimary = Zotero.CreatorTypes.getPrimaryIDForType(this.getType());
Zotero.debug('old primary was ' + oldPrimary);
Zotero.debug('old type was ' + creators[i].creatorTypeID);
if (oldPrimary == creators[i].creatorTypeID) {
var newPrimary = Zotero.CreatorTypes.getPrimaryIDForType(itemTypeID);
Zotero.debug('new primary is ' + newPrimary);
}
var target = newPrimary ? newPrimary : 2;
// Reset to contributor (creatorTypeID 2), which exists in all
this.setCreator(i, creators[i].firstName,
creators[i].lastName, 2, creators[i].fieldMode);
creators[i].lastName, target, creators[i].fieldMode);
}
}
}