suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add tests to CrossRef lookup, and make it always try to look up items with a DOI regardless of item type specified

Browse Source
This commit is contained in:
Simon Kornblith 2011-06-23 08:06:23 +00:00
parent 5aa511cf6d
commit 33e1ed9532
1 changed files with 48 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
translators/CrossRef.js
View File

@ -4,18 +4,20 @@
"label":"CrossRef", "label":"CrossRef",
"creator":"Simon Kornblith", "creator":"Simon Kornblith",
"target":"^https?://partneraccess\\.oclc\\.org/", "target":"^https?://partneraccess\\.oclc\\.org/",
"minVersion":"3.0", "minVersion":"2.1.9",
"maxVersion":"", "maxVersion":"",
"priority":90, "priority":90,
"browserSupport":"gcs",
"inRepository":true, "inRepository":true,
"lastUpdated":"2011-06-21 02:10:40" "lastUpdated":"2011-06-23 08:05:22"
} }
/* CrossRef uses unixref; documentation at http://www.crossref.org/schema/documentation/unixref1.0/unixref.html */ /* CrossRef uses unixref; documentation at http://www.crossref.org/schema/documentation/unixref1.0/unixref.html */
var ns; var ns;
function detectSearch(item) { function detectSearch(item) {
if(item.itemType == "journalArticle") { // query: should we make this more forgiving?
if(item.itemType === "journalArticle" || item.DOI) {
return true; return true;
} }
return false; return false;
@ -213,7 +215,7 @@ function processCrossRef(xmlOutput) {
item.url = ZU.xpathText(refXML, 'c:doi_data/c:resource', ns); item.url = ZU.xpathText(refXML, 'c:doi_data/c:resource', ns);
item.title = ZU.xpathText(refXML, 'c:titles[1]/c:title[1]', ns); item.title = ZU.xpathText(refXML, 'c:titles[1]/c:title[1]', ns);
Zotero.debug(item); //Zotero.debug(JSON.stringify(item, null, 4));
item.complete(); item.complete();
return true; return true;
@ -225,6 +227,8 @@ function doSearch(item) {
if(co.indexOf("url_ver=") == -1) { if(co.indexOf("url_ver=") == -1) {
co = "url_ver=Z39.88-2004&"+co; co = "url_ver=Z39.88-2004&"+co;
} }
} else if(item.DOI) {
var co = "url_ver=Z39.88-2004&&rft_id=info:doi/"+ZU.cleanDOI(item.DOI.toString());
} else { } else {
var co = Zotero.Utilities.createContextObject(item); var co = Zotero.Utilities.createContextObject(item);
} }
@ -236,3 +240,43 @@ function doSearch(item) {
Zotero.wait(); Zotero.wait();
} }
/** BEGIN TEST CASES **/
var testCases = [
{
"type": "search",
"input": {
"DOI":"10.1017/CCOL0521858429.016"
},
"items": [
{
"itemType": "bookSection",
"creators": [
{
"creatorType": "editor",
"firstName": "John",
"lastName": "Rodden"
},
{
"creatorType": "author",
"firstName": "Christopher",
"lastName": "Hitchens"
}
],
"notes": [],
"tags": [],
"seeAlso": [],
"attachments": [],
"bookTitle": "The Cambridge Companion to George Orwell",
"place": "Cambridge",
"ISBN": "0521858429, 9780521858427, 0521675073, 9780521675079",
"publisher": "Cambridge University Press",
"pages": "201-207",
"DOI": "10.1017/CCOL0521858429.016",
"url": "http://cco.cambridge.org/extract?id=ccol0521858429_CCOL0521858429A016",
"title": "Why Orwell still matters",
"libraryCatalog": "CrossRef"
}
]
}
]
/** END TEST CASES **/