suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Additional try/catch to fix NS_ERROR_UNEXPECTED from tree select

Browse Source 
Follow-up to 7cd1439928
This commit is contained in:
Dan Stillman 2018-01-02 20:17:51 -05:00
parent 2bc44dddd1
commit 374eefada1
1 changed files with 23 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
chrome/content/zotero/xpcom/itemTreeView.js
View File

@ -1869,19 +1869,28 @@ Zotero.ItemTreeView.prototype.selectItem = Zotero.Promise.coroutine(function* (i
// refreshed. To get around this, we wait for a select event that's triggered by // refreshed. To get around this, we wait for a select event that's triggered by
// itemSelected() when it's done. // itemSelected() when it's done.
let promise; let promise;
if (this.selection.selectEventsSuppressed) { try {
this.selection.select(row); if (this.selection.selectEventsSuppressed) {
} this.selection.select(row);
else { }
promise = this.waitForSelect(); else {
this.selection.select(row); promise = this.waitForSelect();
} this.selection.select(row);
}
// If |expand|, open row if container // If |expand|, open row if container
if (expand && this.isContainer(row) && !this.isContainerOpen(row)) { if (expand && this.isContainer(row) && !this.isContainerOpen(row)) {
this.toggleOpenState(row); this.toggleOpenState(row);
}
this.selection.select(row);
}
// Ignore NS_ERROR_UNEXPECTED from nsITreeSelection::select(), apparently when the tree
// disappears before it's called (though I can't reproduce it):
//
// https://forums.zotero.org/discussion/comment/297039/#Comment_297039
catch (e) {
Zotero.logError(e);
} }
this.selection.select(row);
if (promise) { if (promise) {
yield promise; yield promise;
@ -2104,10 +2113,6 @@ Zotero.ItemTreeView.prototype.rememberSelection = function (selection) {
this._treebox.beginUpdateBatch(); this._treebox.beginUpdateBatch();
} }
// Use try/catch to work around NS_ERROR_UNEXPECTED from nsITreeSelection::toggleSelect(),
// apparently when the tree disappears before it's called (though I can't reproduce it):
//
// https://forums.zotero.org/discussion/69226/papers-become-invisible-in-the-middle-pane
try { try {
for (let i = 0; i < selection.length; i++) { for (let i = 0; i < selection.length; i++) {
if (this._rowMap[selection[i]] != null) { if (this._rowMap[selection[i]] != null) {
@ -2133,6 +2138,10 @@ Zotero.ItemTreeView.prototype.rememberSelection = function (selection) {
} }
} }
} }
// Ignore NS_ERROR_UNEXPECTED from nsITreeSelection::toggleSelect(), apparently when the tree
// disappears before it's called (though I can't reproduce it):
//
// https://forums.zotero.org/discussion/69226/papers-become-invisible-in-the-middle-pane
catch (e) { catch (e) {
Zotero.logError(e); Zotero.logError(e);
} }