suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Write sessionID into the doc on new session creation

Browse Source
This commit is contained in:
Adomas Venčkauskas 2017-05-03 14:34:00 +03:00
parent 6336a30cb9
commit 37fa0c203f
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chrome/content/zotero/xpcom/integration.js
View File

@ -1032,6 +1032,8 @@ Zotero.Integration.Document.prototype._getSession = Zotero.Promise.coroutine(fun
this._session = this._createNewSession(data); this._session = this._createNewSession(data);
try { try {
yield this._session.setData(data); yield this._session.setData(data);
// this._createNewSession() updates sessionID, which we need to store back into the doc
this._doc.setDocumentData(me._session.data.serialize())
} catch(e) { } catch(e) {
// make sure style is defined // make sure style is defined
if(e instanceof Zotero.Exception.Alert && e.name === "integration.error.invalidStyle") { if(e instanceof Zotero.Exception.Alert && e.name === "integration.error.invalidStyle") {

4
test/tests/integrationTest.js
View File

@ -352,10 +352,10 @@ describe("Zotero.Integration", function () {
assert.isFalse(setDocumentDataSpy.called); assert.isFalse(setDocumentDataSpy.called);
}); });
it('should not call doc.setDocumentData when document communicates for first time since restart, but has data', function* () { it('should call doc.setDocumentData when document communicates for first time since restart to write new sessionID', function* () {
Zotero.Integration.sessions = {}; Zotero.Integration.sessions = {};
yield execCommand('addEditCitation', docID); yield execCommand('addEditCitation', docID);
assert.isFalse(setDocumentDataSpy.called); assert.isTrue(setDocumentDataSpy.calledOnce);
}); });
describe('when style used in the document does not exist', function() { describe('when style used in the document does not exist', function() {