suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes #288, Add back comma after last name in item edit pane

Browse Source
This commit is contained in:
Dan Stillman 2006-09-23 23:40:10 +00:00
parent 73ff76aa39
commit 3b55fe520c
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
chrome/chromeFiles/content/scholar/itemPane.js
View File

@ -395,6 +395,13 @@ var ScholarItemPane = new function()
tabindex tabindex
) )
); );
// Comma
var comma = document.createElement('label');
comma.setAttribute('value', ',');
comma.className = 'comma';
firstlast.appendChild(comma);
firstlast.appendChild( firstlast.appendChild(
createValueElement( createValueElement(
firstName, firstName,
@ -465,6 +472,7 @@ var ScholarItemPane = new function()
var button = row.lastChild.lastChild.previousSibling.previousSibling; var button = row.lastChild.lastChild.previousSibling.previousSibling;
var hbox = button.previousSibling; var hbox = button.previousSibling;
var lastName = hbox.firstChild; var lastName = hbox.firstChild;
var comma = hbox.firstChild.nextSibling;
var firstName = hbox.lastChild; var firstName = hbox.lastChild;
// Switch to single-field mode // Switch to single-field mode
@ -485,6 +493,7 @@ var ScholarItemPane = new function()
// Hide first name field and prepend to last name field // Hide first name field and prepend to last name field
firstName.setAttribute('hidden', true); firstName.setAttribute('hidden', true);
comma.setAttribute('hidden', true);
var first = _getFieldValue(firstName); var first = _getFieldValue(firstName);
if (first && first != _defaultFirstName) if (first && first != _defaultFirstName)
{ {
@ -537,6 +546,7 @@ var ScholarItemPane = new function()
} }
firstName.setAttribute('hidden', false); firstName.setAttribute('hidden', false);
comma.setAttribute('hidden', false);
} }
if (!initial) if (!initial)
@ -863,7 +873,7 @@ var ScholarItemPane = new function()
function getCreatorFields(row){ function getCreatorFields(row){
var type = row.getElementsByTagName('label')[0].getAttribute('value'); var type = row.getElementsByTagName('label')[0].getAttribute('value');
var label1 = row.getElementsByTagName('hbox')[0].firstChild.firstChild; var label1 = row.getElementsByTagName('hbox')[0].firstChild.firstChild;
var label2 = label1.nextSibling; var label2 = label1.parentNode.lastChild;
return { return {
lastName: label1.firstChild ? label1.firstChild.nodeValue lastName: label1.firstChild ? label1.firstChild.nodeValue

11
chrome/chromeFiles/skin/default/scholar/overlay.css
View File

@ -201,6 +201,17 @@
font-weight: bold; font-weight: bold;
} }
/* no space between last name and comma */
#editpane-dynamic-fields row hbox label:first-child
{
margin-right:1px;
}
#editpane-dynamic-fields row hbox label.comma
{
margin-left:0;
}
#scholar-splitter #scholar-splitter
{ {
border-top: none; border-top: none;