suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Amend comment regarding citationsByIndex keys sort order

Browse Source
This commit is contained in:
Adomas Venčkauskas 2018-02-06 16:08:06 +02:00
parent 4add3ec44c
commit 46854b6b23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chrome/content/zotero/xpcom/integration.js
View File

@ -1517,7 +1517,7 @@ Zotero.Integration.Session.prototype.getCiteprocLists = function() {
var fieldToCitationIdxMapping = []; var fieldToCitationIdxMapping = [];
var citationToFieldIdxMapping = {}; var citationToFieldIdxMapping = {};
var i = 0; var i = 0;
// This relies on the order of citationsByIndex keys being stable and sorted by insertion order // This relies on the order of citationsByIndex keys being stable and sorted in ascending order
// Which it seems to currently be true for every modern JS engine, so we're probably fine // Which it seems to currently be true for every modern JS engine, so we're probably fine
for(let idx in this.citationsByIndex) { for(let idx in this.citationsByIndex) {
citations.push([this.citationsByIndex[idx].citationID, this.citationsByIndex[idx].properties.noteIndex]); citations.push([this.citationsByIndex[idx].citationID, this.citationsByIndex[idx].properties.noteIndex]);