From 4df28f93cbcda5659b33de9ee4db474c892a4571 Mon Sep 17 00:00:00 2001 From: Simon Kornblith Date: Sat, 6 Nov 2010 21:35:06 +0000 Subject: [PATCH] don't use getters, since they probably don't save much memory and they don't seem to work with Fx3.6 wrappers --- chrome/content/zotero/xpcom/translation/item_local.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/chrome/content/zotero/xpcom/translation/item_local.js b/chrome/content/zotero/xpcom/translation/item_local.js index 240c66ad9..61eb9b7ef 100644 --- a/chrome/content/zotero/xpcom/translation/item_local.js +++ b/chrome/content/zotero/xpcom/translation/item_local.js @@ -623,10 +623,6 @@ Zotero.Translate.ItemGetter.prototype = { * Converts an item to array format */ "_itemToArray":function(returnItem) { - const makeGetter = function(returnItemArray, fieldName) { - return function() { return returnItemArray[fieldName] }; - } - // TODO use Zotero.Item#serialize() var returnItemArray = returnItem.toArray(); @@ -652,10 +648,10 @@ Zotero.Translate.ItemGetter.prototype = { } if(baseName) { - returnItemArray.__defineGetter__(baseName, makeGetter(returnItemArray, fieldName)); - returnItemArray.uniqueFields.__defineGetter__(baseName, makeGetter(returnItemArray, fieldName)); + returnItemArray[baseName] = returnItemArray[fieldName]; + returnItemArray.uniqueFields[baseName] = returnItemArray[fieldName]; } else { - returnItemArray.uniqueFields.__defineGetter__(fieldName, makeGetter(returnItemArray, fieldName)); + returnItemArray.uniqueFields[fieldName] = returnItemArray[fieldName]; } } }