suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Maintain open state of groups on collectionTreeView refresh()

Browse Source
This commit is contained in:
Dan Stillman 2016-07-02 01:26:44 -04:00
parent 86b5042781
commit 51b3951fb0
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
chrome/content/zotero/xpcom/collectionTreeView.js
View File

@ -262,6 +262,7 @@ Zotero.CollectionTreeView.prototype.refresh = Zotero.Promise.coroutine(function*
new Zotero.CollectionTreeRow('group', group), new Zotero.CollectionTreeRow('group', group),
added++ added++
); );
added += yield this._expandRow(newRows, added - 1);
} }
} }

29
test/tests/collectionTreeViewTest.js
View File

@ -37,6 +37,35 @@ describe("Zotero.CollectionTreeView", function() {
assert.strictEqual(Zotero.Prefs.get('duplicateLibraries'), ""); assert.strictEqual(Zotero.Prefs.get('duplicateLibraries'), "");
assert.strictEqual(Zotero.Prefs.get('unfiledLibraries'), ""); assert.strictEqual(Zotero.Prefs.get('unfiledLibraries'), "");
}); });
it("should maintain open state of group", function* () {
var group1 = yield createGroup();
var group2 = yield createGroup();
var group1Row = cv.getRowIndexByID(group1.treeViewID);
var group2Row = cv.getRowIndexByID(group2.treeViewID);
// Open group 1 and close group 2
if (!cv.isContainerOpen(group1Row)) {
yield cv.toggleOpenState(group1Row);
}
if (cv.isContainerOpen(group2Row)) {
yield cv.toggleOpenState(group2Row);
}
// Don't wait for delayed save
cv._saveOpenStates();
group1Row = cv.getRowIndexByID(group1.treeViewID);
group2Row = cv.getRowIndexByID(group2.treeViewID);
yield cv.refresh();
// Group rows shouldn't have changed
assert.equal(cv.getRowIndexByID(group1.treeViewID), group1Row);
assert.equal(cv.getRowIndexByID(group2.treeViewID), group2Row);
// Group open states shouldn't have changed
assert.isTrue(cv.isContainerOpen(group1Row));
assert.isFalse(cv.isContainerOpen(group2Row));
});
}); });
describe("collapse/expand", function () { describe("collapse/expand", function () {