suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #1094, dataObjectUtilities.equals() misdescription

Browse Source
This commit is contained in:
Dan Stillman 2016-09-19 01:01:01 -04:00
parent 21d3ca298b
commit 520220a69a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
chrome/content/zotero/xpcom/data/dataObjectUtilities.js
View File

@ -155,10 +155,12 @@ Zotero.DataObjectUtilities = {
/** /**
* Determine whether two API JSON objects are equivalent * Determine whether two API JSON objects are equivalent
* *
* Note: Currently unused
*
* @param {Object} data1 - API JSON of first object * @param {Object} data1 - API JSON of first object
* @param {Object} data2 - API JSON of second object * @param {Object} data2 - API JSON of second object
* @param {Array} [ignoreFields] - Fields to ignore * @param {Array} [ignoreFields] - Fields to ignore
* @param {Boolean} - True if objects are the same, false if not * @return {Boolean} - True if objects are the same, false if not
*/ */
equals: function (data1, data2, ignoreFields) { equals: function (data1, data2, ignoreFields) {
var skipFields = {}; var skipFields = {};
@ -182,7 +184,7 @@ Zotero.DataObjectUtilities = {
let changed = this._fieldChanged(field, val1, val2); let changed = this._fieldChanged(field, val1, val2);
if (changed) { if (changed) {
return true; return false;
} }
skipFields[field] = true; skipFields[field] = true;
@ -200,10 +202,10 @@ Zotero.DataObjectUtilities = {
continue; continue;
} }
return true; return false;
} }
return false; return true;
}, },
_fieldChanged: function (fieldName, field1, field2) { _fieldChanged: function (fieldName, field1, field2) {