suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix weird test failure after c5cd38b4a5

Browse Source 
The change in c5cd38b4a5 seems like it shouldn't have had any effect,
but creating an empty Set before yielding somehow avoided a race
condition with the subsequent updateSession call.
This commit is contained in:
Dan Stillman 2018-03-29 08:27:18 -04:00
parent c5cd38b4a5
commit 52c1249523
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
chrome/content/zotero/xpcom/server_connector.js
View File

@ -164,17 +164,17 @@ Zotero.Server.Connector.SaveSession.prototype.update = async function (libraryID
}; };
Zotero.Server.Connector.SaveSession.prototype._addObjects = async function (objectType, objects) { Zotero.Server.Connector.SaveSession.prototype._addObjects = async function (objectType, objects) {
// Update the objects with the current target data, in case it changed since the save began
await this._updateObjects({
[objectType]: objects
});
if (!this._objects[objectType]) { if (!this._objects[objectType]) {
this._objects[objectType] = new Set(); this._objects[objectType] = new Set();
} }
for (let object of objects) { for (let object of objects) {
this._objects[objectType].add(object); this._objects[objectType].add(object);
} }
// Update the objects with the current target data, in case it changed since the save began
await this._updateObjects({
[objectType]: objects
});
}; };
/** /**