suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for error when creating new items or attachments with saved search selected

Browse Source 
Item.getSource() no longer protests when called on a regular item (it just returns false)
This commit is contained in:
Dan Stillman 2006-10-31 21:03:08 +00:00
parent 58150dd94e
commit 58558c37a3
2 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chrome/content/zotero/xpcom/data_access.js
View File

@ -1117,7 +1117,7 @@ Zotero.Item.prototype.getSource = function(){
var Type = 'Attachment';
}
else {
throw ("getSource() can only be called on items of type 'note' or 'attachment'");
return false;
}
var sql = "SELECT sourceItemID FROM item" + Type + "s WHERE itemID=" + this.getID();

19
chrome/content/zotero/xpcom/itemTreeView.js
View File

@ -201,8 +201,16 @@ Zotero.ItemTreeView.prototype.notify = function(action, type, ids)
}
else if(action == 'add')
{
// If no quicksearch, process new items manually
if (quicksearch.value == '')
// If saved search, just rerun search
if (this._itemGroup.isSearch())
{
this.refresh();
madeChanges = true;
}
// If not a quicksearch and not background window saved search,
// process new items manually
else if (quicksearch.value == '')
{
var items = Zotero.Items.get(ids);
@ -603,9 +611,16 @@ Zotero.ItemTreeView.prototype.sort = function()
Zotero.ItemTreeView.prototype.selectItem = function(id)
{
var row = this._itemRowMap[id];
// If row with id not visible, check to see if it's hidden under a parent
if(row == null)
{
var item = Zotero.Items.get(id);
var parent = item.getSource();
if (!parent)
{
// No parent -- it's not here
return false;
}
this.toggleOpenState(this._itemRowMap[item.getSource()]); //opens the parent of the item
row = this._itemRowMap[id];
}