suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix attaching notes and tags

Browse Source
This commit is contained in:
Simon Kornblith 2010-11-06 04:07:04 +00:00
parent 65ffe8ae4c
commit 58bfd33556
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
chrome/content/zotero/xpcom/translation/item_local.js
View File

@ -417,12 +417,15 @@ Zotero.Translate.ItemSaver.prototype = {
}, },
"_saveNotes":function(item, parentID) { "_saveNotes":function(item, parentID) {
for each(var note in item.notes) { Zotero.debug(item.notes);
for(var i=0; i<item.notes.length; i++) {
var note = item.notes[i];
Zotero.debug(note);
var myNote = new Zotero.Item('note'); var myNote = new Zotero.Item('note');
myNote.libraryID = this._libraryID; myNote.libraryID = this._libraryID;
myNote.setNote(typeof note == "object" ? note.note : note); myNote.setNote(typeof note == "object" ? note.note : note);
if (myID) { if(parentID) {
myNote.setSource(myID); myNote.setSource(parentID);
} }
var noteID = myNote.save(); var noteID = myNote.save();
@ -456,18 +459,20 @@ Zotero.Translate.ItemSaver.prototype = {
tagsToAdd[0] = []; // user tags tagsToAdd[0] = []; // user tags
tagsToAdd[1] = []; // automatic tags tagsToAdd[1] = []; // automatic tags
for each(var tag in item.tags) { for(var i=0; i<item.tags.length; i++) {
var tag = item.tags[i];
if(typeof(tag) == "string") { if(typeof(tag) == "string") {
// accept strings in tag array as automatic tags, or, if // accept strings in tag array as automatic tags, or, if
// importing, as non-automatic tags // importing, as non-automatic tags
if(this._forceTagType) { if(this._forceTagType) {
tagsToAdd[this._forceTagType].push(tag); tagsToAdd[this._forceTagType].push(tag);
} else { } else {
tagsToAdd[1].push(tag); tagsToAdd[0].push(tag);
} }
} else if(typeof(tag) == "object") { } else if(typeof(tag) == "object") {
// also accept objects // also accept objects
if(tag.tag) { if(tag.tag || tag.name) {
if(this._forceTagType) { if(this._forceTagType) {
var tagType = this._forceTagType; var tagType = this._forceTagType;
} else if(tag.type) { } else if(tag.type) {
@ -475,16 +480,12 @@ Zotero.Translate.ItemSaver.prototype = {
} else { } else {
var tagType = 0; var tagType = 0;
} }
if(!tagsToAdd[tagType]) {
tagsToAdd[tagType] = [];
}
tagsToAdd[tagType].push(tag.tag ? tag.tag : tag.name); tagsToAdd[tagType].push(tag.tag ? tag.tag : tag.name);
} }
} }
} }
for (var type in tagsToAdd) { for (var type in [0, 1]) {
if (tagsToAdd[type].length) { if (tagsToAdd[type].length) {
newItem.addTags(tagsToAdd[type], type); newItem.addTags(tagsToAdd[type], type);
} }