suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Backoff and Retry-After header parsing

Browse Source
This commit is contained in:
Dan Stillman 2018-06-12 15:13:00 -04:00
parent 79d7c15d4f
commit 5ddbe433b9
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
chrome/content/zotero/xpcom/sync/syncAPIClient.js
View File

@ -820,7 +820,7 @@ Zotero.Sync.APIClient.prototype = {
_checkBackoff: function (xmlhttp) { _checkBackoff: function (xmlhttp) {
var backoff = xmlhttp.getResponseHeader("Backoff"); var backoff = xmlhttp.getResponseHeader("Backoff");
if (backoff && Number.isInteger(backoff)) { if (backoff && parseInt(backoff) == backoff) {
// TODO: Update status? // TODO: Update status?
this.caller.pause(backoff * 1000); this.caller.pause(backoff * 1000);
} }
@ -831,7 +831,7 @@ Zotero.Sync.APIClient.prototype = {
var retryAfter = xmlhttp.getResponseHeader("Retry-After"); var retryAfter = xmlhttp.getResponseHeader("Retry-After");
var delay; var delay;
if (!retryAfter) return false; if (!retryAfter) return false;
if (!Number.isInteger(retryAfter)) { if (parseInt(retryAfter) != retryAfter) {
Zotero.logError(`Invalid Retry-After delay ${retryAfter}`); Zotero.logError(`Invalid Retry-After delay ${retryAfter}`);
return false; return false;
} }

4
test/tests/syncAPIClientTest.js
View File

@ -174,7 +174,7 @@ describe("Zotero.Sync.APIClient", function () {
req.respond( req.respond(
503, 503,
{ {
"Retry-After": 5 "Retry-After": "5"
}, },
"" ""
); );
@ -183,7 +183,7 @@ describe("Zotero.Sync.APIClient", function () {
req.respond( req.respond(
503, 503,
{ {
"Retry-After": 10 "Retry-After": "10"
}, },
"" ""
); );