suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

When changing item type, reset any creator types that don't exist in the target item type to 'contributor', which exists in all

Browse Source
This commit is contained in:
Dan Stillman 2006-10-05 23:36:05 +00:00
parent d59a9d6b3f
commit 64d7c64ee2
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
chrome/content/zotero/xpcom/data_access.js
View File

@ -161,8 +161,9 @@ Zotero.Item.prototype.setType = function(itemTypeID){
return true;
}
// If existing type, clear fields from old type that aren't in new one
// If existing type
if (this.getType()){
// Clear fields from old type that aren't in new one
var sql = 'SELECT fieldID FROM itemTypeFields '
+ 'WHERE itemTypeID=' + this.getType() + ' AND fieldID NOT IN '
+ '(SELECT fieldID FROM itemTypeFields WHERE itemTypeID='
@ -174,6 +175,19 @@ Zotero.Item.prototype.setType = function(itemTypeID){
this.setField(obsoleteFields[i],false);
}
}
// And reset custom creator types to the default
var creators = this.getCreators();
if (creators){
for each(var creator in creators){
if (!Zotero.CreatorTypes.isValidForItemType(creator['creatorTypeID'], itemTypeID))
{
// Reset to contributor (creatorTypeID 2), which exists in all
this.setCreator(orderIndex, creator['firstName'],
creator['lastName'], 2, creator['fieldMode']);
}
}
}
}
this._data['itemTypeID'] = itemTypeID;
@ -2910,6 +2924,7 @@ Zotero.CreatorTypes = new function(){
this.constructor.prototype = new Zotero.CachedTypes();
this.getTypesForItemType = getTypesForItemType;
this.isValidForItemType = isValidForItemType;
this.getPrimaryIDForType = getPrimaryIDForType;
this._typeDesc = 'creator type';
@ -2926,6 +2941,14 @@ Zotero.CreatorTypes = new function(){
return Zotero.DB.query(sql, itemTypeID);
}
function isValidForItemType(creatorTypeID, itemTypeID){
var sql = "SELECT COUNT(*) FROM itemTypeCreatorTypes "
+ "WHERE itemTypeID=? AND creatorTypeID=?";
return !!Zotero.DB.valueQuery(sql, [itemTypeID, creatorTypeID]);
}
function getPrimaryIDForType(itemTypeID){
var sql = "SELECT creatorTypeID FROM itemTypeCreatorTypes "
+ "WHERE itemTypeID=? AND primaryField=1";