suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Work around an SQLite limit that can cause a 1.0->2.0 upgrade error in very rare cases (in code from July 2008)

Browse Source
This commit is contained in:
Dan Stillman 2010-03-15 07:16:05 +00:00
parent a8e03b1830
commit 65f493471f
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
chrome/content/zotero/xpcom/schema.js
View File

@ -1978,12 +1978,25 @@ Zotero.Schema = new function(){
var rows = Zotero.DB.columnQuery("SELECT GROUP_CONCAT(valueID) FROM itemDataValues GROUP BY value HAVING COUNT(*) > 1"); var rows = Zotero.DB.columnQuery("SELECT GROUP_CONCAT(valueID) FROM itemDataValues GROUP BY value HAVING COUNT(*) > 1");
for each(var row in rows) { for each(var row in rows) {
var ids = row.split(','); var ids = row.split(',');
var id = parseInt(ids[0]);
var deleteIDs = []; var deleteIDs = [];
for (var j=1; j<ids.length; j++) { for (var j=1; j<ids.length; j++) {
deleteIDs.push(parseInt(ids[j])); deleteIDs.push(parseInt(ids[j]));
} }
Zotero.DB.query("UPDATE itemData SET valueID=? WHERE valueID IN (" + deleteIDs.map(function () '?').join() + ")", [parseInt(ids[0])].concat(deleteIDs));
Zotero.DB.query("DELETE FROM itemDataValues WHERE valueID IN (" + deleteIDs.map(function () '?').join() + ")", deleteIDs); var done = 0;
var max = 998; // compiled limit
var num = deleteIDs.length;
do {
var chunk = deleteIDs.splice(0, max);
Zotero.DB.query("UPDATE itemData SET valueID=? WHERE valueID IN (" + chunk.map(function () '?').join() + ")", [id].concat(chunk));
Zotero.DB.query("DELETE FROM itemDataValues WHERE valueID IN (" + chunk.map(function () '?').join() + ")", chunk);
done += chunk.length;
}
while (done < num);
} }
Zotero.DB.query("CREATE UNIQUE INDEX itemDataValues_value ON itemDataValues(value)"); Zotero.DB.query("CREATE UNIQUE INDEX itemDataValues_value ON itemDataValues(value)");