suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #595 from aurimasv/dup-isbn

Browse Source 
Fix duplicate matching when ISBN is non-sensical
This commit is contained in:
Dan Stillman 2014-12-10 17:03:38 -05:00
commit 67f28eada3
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
chrome/content/zotero/xpcom/duplicates.js
View File

@ -170,7 +170,9 @@ Zotero.Duplicates.prototype._findDuplicates = function () {
} }
// If no comparison function, check for exact match // If no comparison function, check for exact match
else { else {
if (rows[i].value !== rows[j].value) { if (!rows[i].value || !rows[j].value
|| (rows[i].value !== rows[j].value)
) {
break; break;
} }
} }
@ -205,8 +207,8 @@ Zotero.Duplicates.prototype._findDuplicates = function () {
var isbnCache = {}; var isbnCache = {};
if (rows) { if (rows) {
for each(var row in rows) { for each(var row in rows) {
row.value = (row.value+'').replace(/[^\dX]+/ig, '').toUpperCase(); //ignore formatting row.value = Zotero.Utilities.cleanISBN('' + row.value);
isbnCache[row.itemID] = row.value; if (row.value) isbnCache[row.itemID] = row.value;
} }
rows.sort(sortByValue); rows.sort(sortByValue);
processRows(); processRows();