suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Addresses #597, Don't iterate Array with for...in

Browse Source
This commit is contained in:
Dan Stillman 2007-03-28 18:10:00 +00:00
parent bc9d904f00
commit 6f39031ed6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
chrome/content/zotero/itemPane.js
View File

@ -252,8 +252,8 @@ var ZoteroItemPane = new function()
} }
var creatorTypes = Zotero.CreatorTypes.getTypesForItemType(_itemBeingEdited.getType()); var creatorTypes = Zotero.CreatorTypes.getTypesForItemType(_itemBeingEdited.getType());
var localized = []; var localized = {};
for (var i in creatorTypes) for (var i=0; i<creatorTypes.length; i++)
{ {
localized[creatorTypes[i]['name']] localized[creatorTypes[i]['name']]
= Zotero.getString('creatorTypes.' + creatorTypes[i]['name']); = Zotero.getString('creatorTypes.' + creatorTypes[i]['name']);
@ -509,9 +509,9 @@ var ZoteroItemPane = new function()
// Generate list of localized field names for display in pop-up // Generate list of localized field names for display in pop-up
if (fieldsToDelete) { if (fieldsToDelete) {
var fieldNames = ""; var fieldNames = "";
for each(var fieldID in fieldsToDelete) { for (var i=0; i<fieldsToDelete.length; i++) {
fieldNames += "\n - " + fieldNames += "\n - " +
Zotero.ItemFields.getLocalizedString(_itemBeingEdited.getType(), fieldID); Zotero.ItemFields.getLocalizedString(_itemBeingEdited.getType(), fieldsToDelete[i]);
} }
var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"] var promptService = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]