suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify comment for Windows drag-and-drop mess

Browse Source
This commit is contained in:
Dan Stillman 2014-07-20 02:50:00 -04:00
parent b8f69d6281
commit 717a440156
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
chrome/content/zotero/xpcom/libraryTreeView.js
View File

@ -198,21 +198,21 @@ Zotero.LibraryTreeView.prototype = {
// and 'copy'/'link' for drags with system-default modifier keys, // and 'copy'/'link' for drags with system-default modifier keys,
// as long as the actions are allowed by the initial effectAllowed set // as long as the actions are allowed by the initial effectAllowed set
// in onDragStart, regardless of the effectAllowed or dropEffect set // in onDragStart, regardless of the effectAllowed or dropEffect set
// in onDragOver. To prevent inaccurate 'copy'/'link' cursors, we set // in onDragOver. It doesn't seem to be possible to use 'copy' for
// effectAllowed to 'move' in onDragStart, which locks the cursor at // the default and 'move' for modified, as we need to in the collections
// 'move'. ('none' still changes the cursor, but 'copy'/'link' do not.) // tree. To prevent inaccurate 'copy'/'link' cursors, we set effectAllowed
// to 'copy' in onDragStart, which locks the cursor at 'copy'. ('none' still
// changes the cursor, but 'move'/'link' do not.) We use 'copy' instead of
// 'move' because with 'move' text can't be dragged to Chrome textareas
// (and probably other places), and that seems worse than always showing
// 'copy' feedback.
// //
// However, since effectAllowed is enforced, leaving it at 'move' // However, since effectAllowed is enforced, leaving it at 'copy'
// would prevent our default 'copy' from working, so we also have to // would prevent our modified 'move' from working, so we also have to
// set effectAllowed here (called from onDragOver) to the same action // set effectAllowed here (called from onDragOver) to the same action
// as the dropEffect. This allows the dropEffect setting (which we use // as the dropEffect. This allows the dropEffect setting (which we use
// in the tree's canDrop() and drop() to determine the desired action) // in the tree's canDrop() and drop() to determine the desired action)
// to be changed, even if the cursor doesn't reflect the new setting. // to be changed, even if the cursor doesn't reflect the new setting.
//
// Update (07/2014): We now use 'copy' for effectAllowed on Windows in
// onDragStart, since with 'move' text can't be dragged to Chrome
// textareas (and probably other places). This locks the cursor at copy,
// even when Shift is used, but that seems less bad.
if (Zotero.isWin) { if (Zotero.isWin) {
event.dataTransfer.effectAllowed = effect; event.dataTransfer.effectAllowed = effect;
} }