From 79a07cad9eee0d2276ed96376635a82eb3e81fa4 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Thu, 2 Feb 2017 18:42:17 -0500 Subject: [PATCH] Return array copy in ItemFields.getItemTypeFields()/getTypeFieldsFromBase() --- chrome/content/zotero/xpcom/data/itemFields.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chrome/content/zotero/xpcom/data/itemFields.js b/chrome/content/zotero/xpcom/data/itemFields.js index 9dcb0983b..67bb7053f 100644 --- a/chrome/content/zotero/xpcom/data/itemFields.js +++ b/chrome/content/zotero/xpcom/data/itemFields.js @@ -204,7 +204,7 @@ Zotero.ItemFields = new function() { throw new Error("Item type field data not found for itemTypeID " + itemTypeID); } - return _itemTypeFields[itemTypeID]; + return [..._itemTypeFields[itemTypeID]]; } @@ -317,7 +317,7 @@ Zotero.ItemFields = new function() { } return _typeFieldIDsByBase[baseFieldID] ? - _typeFieldIDsByBase[baseFieldID] : false; + [..._typeFieldIDsByBase[baseFieldID]] : false; }