suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary lastUpdated optimization in translator regexp, allowing lastUpdated to be anywhere in the JSON

Browse Source
This commit is contained in:
Dan Stillman 2011-07-21 19:16:19 +00:00
parent 491c44c74c
commit 7b469e3d6f
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
chrome/content/zotero/xpcom/translation/translator.js
View File

@ -443,17 +443,7 @@ Zotero.Translator = function(file, json, code) {
var str = {};
cStream.readString(MAX_INFO_LENGTH, str);
// We assume lastUpdated is at the end to avoid running the regexp on more than necessary
var lastUpdatedIndex = str.value.indexOf('"lastUpdated"');
if (lastUpdatedIndex == -1) {
this.logError("Invalid or missing translator metadata JSON object in " + file.leafName);
fStream.close();
return;
}
// Add 50 characters to clear lastUpdated timestamp and final "}"
var header = str.value.substr(0, lastUpdatedIndex + 50);
var m = infoRe.exec(header);
var m = infoRe.exec(str.value);
if (!m) {
this.logError("Invalid or missing translator metadata JSON object in " + file.leafName);
fStream.close();