From 8c4e2f0d49fa0575eb9e67b14ed41cf6425a636c Mon Sep 17 00:00:00 2001 From: Simon Kornblith Date: Thu, 12 Jul 2012 10:01:59 -0400 Subject: [PATCH] Fix data mismatch false positives --- .../content/zotero/tools/testTranslators/translatorTester.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chrome/content/zotero/tools/testTranslators/translatorTester.js b/chrome/content/zotero/tools/testTranslators/translatorTester.js index 1675b67e5..bc42d512c 100644 --- a/chrome/content/zotero/tools/testTranslators/translatorTester.js +++ b/chrome/content/zotero/tools/testTranslators/translatorTester.js @@ -507,7 +507,7 @@ Zotero_TranslatorTester.prototype._checkResult = function(test, translate, retur if(!this._compare(testItem, translatedItem)) { // Show diff - this._debug(this, "Data mismatch detected:"); + this._debug(this, "TranslatorTester: Data mismatch detected:"); this._debug(this, this._generateDiff(testItem, translatedItem)); // Save items. This makes it easier to correct tests automatically. @@ -602,7 +602,7 @@ Zotero_TranslatorTester.prototype._compare = function(a, b) { } for(var key in a) { if(!a.hasOwnProperty(key)) continue; - if(!b.hasOwnProperty(key)) return false; + if(a[key] !== false && !b.hasOwnProperty(key)) return false; if(!this._compare(a[key], b[key])) return false; } for(var key in b) {