From 8e4de076d1b08152bdbd0d4f2500480143193669 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Fri, 5 Jan 2007 20:50:40 +0000 Subject: [PATCH] Fix itemTreeView.getSortField() and getSortDirection() if no column selected -- this was breaking report generation on initial installs --- chrome/content/zotero/xpcom/itemTreeView.js | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/chrome/content/zotero/xpcom/itemTreeView.js b/chrome/content/zotero/xpcom/itemTreeView.js index 10c85b7ac..23fd83ddc 100644 --- a/chrome/content/zotero/xpcom/itemTreeView.js +++ b/chrome/content/zotero/xpcom/itemTreeView.js @@ -840,14 +840,24 @@ Zotero.ItemTreeView.prototype.getSortedItems = function() { } Zotero.ItemTreeView.prototype.getSortField = function() { - var col = this._treebox.columns.getSortedColumn().id; + var column = this._treebox.columns.getSortedColumn() + if (!column) { + return false; + } // zotero.items._________.column - return col.substring(13, col.length-7); + return column.substring(13, column.length-7); } +/* + * Returns 'ascending' or 'descending' + */ Zotero.ItemTreeView.prototype.getSortDirection = function() { - return this._treebox.columns.getSortedColumn().element.getAttribute('sortDirection'); + var column = this._treebox.columns.getSortedColumn(); + if (!column) { + return 'ascending'; + } + return column.element.getAttribute('sortDirection'); }