suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't cause problems if no callback passed to Zotero.Attachments methods

Browse Source
This commit is contained in:
Simon Kornblith 2012-06-02 17:05:23 -04:00
parent 221d1da340
commit 90bead86ed
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
chrome/content/zotero/xpcom/attachments.js
View File

@ -220,7 +220,7 @@ Zotero.Attachments = new function(){
var urlRe = /^https?:\/\/[^\s]*$/;
var matches = urlRe.exec(url);
if (!matches) {
callback(false);
if(callback) callback(false);
throw ("Invalid URL '" + url + "' in Zotero.Attachments.importFromURL()");
}
@ -302,7 +302,7 @@ Zotero.Attachments = new function(){
+ "'application/pdf' in Attachments.importFromURL()";
Zotero.debug(errString, 2);
attachmentItem.erase();
callback(false, new Error(errString));
if(callback) callback(false, new Error(errString));
return;
}
@ -330,7 +330,7 @@ Zotero.Attachments = new function(){
catch (e) {
// Clean up
attachmentItem.erase();
callback(false, e);
if(callback) callback(false, e);
throw (e);
}
@ -616,7 +616,7 @@ Zotero.Attachments = new function(){
// Clean up
var item = Zotero.Items.get(itemID);
item.erase();
callback(false, e);
if(callback) callback(false, e);
throw (e);
}