From 91ef56147446e6147d0ad97d5f0317400f99e5a8 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Wed, 30 Aug 2017 18:22:00 -0400 Subject: [PATCH] Fix test failure after 94c4445475 If the styled textbox (i.e., TinyMCE) isn't initialized, .value now returns null instead of throwing. --- test/tests/itemPaneTest.js | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/test/tests/itemPaneTest.js b/test/tests/itemPaneTest.js index f9e6534bd..73ec6e760 100644 --- a/test/tests/itemPaneTest.js +++ b/test/tests/itemPaneTest.js @@ -257,23 +257,18 @@ describe("Item pane", function () { var item = new Zotero.Item('note'); var id = yield item.saveTx(); + var noteEditor = doc.getElementById('zotero-note-editor'); + // Wait for the editor - var noteBox = doc.getElementById('zotero-note-editor'); - var val = false; - do { - try { - val = noteBox.noteField.value; - } - catch (e) {} - yield Zotero.Promise.delay(1); - } - while (val === false) - assert.equal(noteBox.noteField.value, ''); + yield new Zotero.Promise((resolve, reject) => { + noteEditor.noteField.onInit(() => resolve()); + }) + assert.equal(noteEditor.noteField.value, ''); item.setNote('

Test

'); yield item.saveTx(); - assert.equal(noteBox.noteField.value, '

Test

'); + assert.equal(noteEditor.noteField.value, '

Test

'); }) })