From 936ef86584fd2e831d8cc1d31667abc38393fc58 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Fri, 16 Jun 2006 21:33:03 +0000
Subject: [PATCH] Fix Item.numNotes() and Item.getNotes() to work on items not
 yet in the DB (return 0 and [], respectively)

---
 chrome/chromeFiles/content/scholar/xpcom/data_access.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/chrome/chromeFiles/content/scholar/xpcom/data_access.js b/chrome/chromeFiles/content/scholar/xpcom/data_access.js
index 3485df419..f9ddbd2a9 100644
--- a/chrome/chromeFiles/content/scholar/xpcom/data_access.js
+++ b/chrome/chromeFiles/content/scholar/xpcom/data_access.js
@@ -737,6 +737,10 @@ Scholar.Item.prototype.removeNote = function(noteID){
 * Returns number of notes in item
 **/
 Scholar.Item.prototype.numNotes = function(){
+	if (!this.getID()){
+		return 0;
+	}
+	
 	var sql = "SELECT COUNT(*) FROM itemNotes WHERE itemID=" + this.getID();
 	return parseInt(Scholar.DB.valueQuery(sql));
 }
@@ -754,6 +758,10 @@ Scholar.Item.prototype.getNote = function(noteID){
 * Returns an array of noteIDs for this item
 **/
 Scholar.Item.prototype.getNotes = function(){
+	if (!this.getID()){
+		return [];
+	}
+	
 	var sql = "SELECT noteID FROM itemNotes WHERE itemID=" + this.getID()
 		+ " ORDER BY dateCreated";
 	return Scholar.DB.columnQuery(sql);