From 759c7bd58b86b18408d786f89e2553e781840f9a Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Wed, 7 Mar 2012 11:34:31 -0500
Subject: [PATCH 01/37] Fix metadata retrieval for files with extended
 characters in filenames

---
 chrome/content/zotero/recognizePDF.js | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/chrome/content/zotero/recognizePDF.js b/chrome/content/zotero/recognizePDF.js
index 11754ec3b..72b6cb3ca 100644
--- a/chrome/content/zotero/recognizePDF.js
+++ b/chrome/content/zotero/recognizePDF.js
@@ -269,7 +269,18 @@ Zotero_RecognizePDF.Recognizer.prototype.recognize = function(file, libraryID, c
 	
 	var args = ['-enc', 'UTF-8', '-nopgbrk', '-layout', '-l', MAX_PAGES];
 	args.push(file.path, cacheFile.path);
-	proc.run(true, args, args.length);
+	try {
+		if (!Zotero.isFx36) {
+			proc.runw(true, args, args.length);
+		}
+		else {
+			proc.run(true, args, args.length);
+		}
+	}
+	catch (e) {
+		Zotero.debug("Error running pdfinfo", 1);
+		Zotero.debug(e, 1);
+	}
 	
 	if(!cacheFile.exists()) {
 		this._callback(false, "recognizePDF.couldNotRead");

From e3ce3bf0c431cc0f0b761812bc6c58165d03c3ad Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Wed, 7 Mar 2012 21:27:51 -0600
Subject: [PATCH 02/37] Include \s in superCleanString, so we match
 non-breaking space and other space characters outside of 7 bit ASCII

---
 chrome/content/zotero/xpcom/utilities.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index cc484142d..15f514015 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -215,8 +215,8 @@ Zotero.Utilities = {
 			throw "superCleanString: argument must be a string";
 		}
 		
-		var x = x.replace(/^[\x00-\x27\x29-\x2F\x3A-\x40\x5B-\x60\x7B-\x7F]+/, "");
-		return x.replace(/[\x00-\x28\x2A-\x2F\x3A-\x40\x5B-\x60\x7B-\x7F]+$/, "");
+		var x = x.replace(/^[\x00-\x27\x29-\x2F\x3A-\x40\x5B-\x60\x7B-\x7F\s]+/, "");
+		return x.replace(/[\x00-\x28\x2A-\x2F\x3A-\x40\x5B-\x60\x7B-\x7F\s]+$/, "");
 	},
 	
 	/**

From 52f47b2510b195b48a45336e4a75e1184cac2556 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Thu, 8 Mar 2012 01:26:45 -0500
Subject: [PATCH 03/37] Fix bug affecting translation-server

---
 chrome/content/zotero/xpcom/translation/translate.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/translation/translate.js b/chrome/content/zotero/xpcom/translation/translate.js
index 061f94914..28ab273cd 100644
--- a/chrome/content/zotero/xpcom/translation/translate.js
+++ b/chrome/content/zotero/xpcom/translation/translate.js
@@ -459,7 +459,7 @@ Zotero.Translate.Sandbox = {
 						var newCallback = function(selectedItems) {
 							callbackExecuted = true;
 							if(haveAsyncHandler) {
-								translate.translate(this._libraryID, this._saveAttachments, selectedItems);
+								translate.translate(translate._libraryID, translate._saveAttachments, selectedItems);
 							} else {
 								returnedItems = selectedItems;
 							}

From 5bdb050b5fe791176eded9e7d8632f78e880d3a1 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Thu, 8 Mar 2012 01:27:03 -0500
Subject: [PATCH 04/37] Support multiple character browsers

---
 chrome/content/zotero/tools/testTranslators/testTranslators.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/tools/testTranslators/testTranslators.js b/chrome/content/zotero/tools/testTranslators/testTranslators.js
index 5c6a6757c..ed1c00d4d 100644
--- a/chrome/content/zotero/tools/testTranslators/testTranslators.js
+++ b/chrome/content/zotero/tools/testTranslators/testTranslators.js
@@ -488,7 +488,7 @@ function init() {
 				hashVars[myVar.substr(0, index)] = myVar.substr(index+1);
 			}
 			
-			if(hashVars["browser"] && /^[a-z]$/.test(hashVars["browser"])
+			if(hashVars["browser"] && /^[a-z]+$/.test(hashVars["browser"])
 					&& hashVars["version"] && /^[0-9a-zA-Z\-._]/.test(hashVars["version"])) {
 				loc = "testResults-"+hashVars["browser"]+"-"+hashVars["version"]+".json";
 			}

From 5816e586fe7e8bf265f5e1d5c6c9f7bac0fca52d Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Thu, 8 Mar 2012 02:34:38 -0600
Subject: [PATCH 05/37] Sort arrays before comparing them. Tag order does not
 matter and authors will not be sorted.

---
 chrome/content/zotero/tools/testTranslators/translatorTester.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/chrome/content/zotero/tools/testTranslators/translatorTester.js b/chrome/content/zotero/tools/testTranslators/translatorTester.js
index c987bc120..29a7a0814 100644
--- a/chrome/content/zotero/tools/testTranslators/translatorTester.js
+++ b/chrome/content/zotero/tools/testTranslators/translatorTester.js
@@ -574,6 +574,8 @@ Zotero_TranslatorTester.prototype._compare = function(i, j) {
 	var match = false;
 	if (Object.prototype.toString.apply(i) === '[object Array]') {
 		if (Object.prototype.toString.apply(j) === '[object Array]') {
+			i.sort();
+			j.sort();
 			do {
 				match = this._compare(i.pop(), j.pop());
 			} while (match && i.length && j.length);

From 1475a79cd1450a71de927550faf6e45709677a74 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Thu, 8 Mar 2012 14:32:38 -0500
Subject: [PATCH 06/37] Open csledit/cslpreview in new tab in existing window
 in Fx

Fixes #75
---
 chrome/content/zotero/preferences/preferences.js  | 8 ++++++--
 chrome/content/zotero/preferences/preferences.xul | 6 +++---
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/chrome/content/zotero/preferences/preferences.js b/chrome/content/zotero/preferences/preferences.js
index a1e8857d0..f08f363b0 100644
--- a/chrome/content/zotero/preferences/preferences.js
+++ b/chrome/content/zotero/preferences/preferences.js
@@ -1914,7 +1914,7 @@ function handleShowInPreferenceChange() {
 /**
  * Opens a URI in the basic viewer in Standalone, or a new window in Firefox
  */
-function openInViewer(uri) {
+function openInViewer(uri, newTab) {
 	var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
 		.getService(Components.interfaces.nsIWindowMediator);
 	const features = "menubar=yes,toolbar=no,location=no,scrollbars,centerscreen,resizable";
@@ -1930,7 +1930,11 @@ function openInViewer(uri) {
 	} else {
 		var win = wm.getMostRecentWindow("navigator:browser");
 		if(win) {
-			win.open(uri, null, features);
+			if(newTab) {
+				win.gBrowser.selectedTab = win.gBrowser.addTab(uri);
+			} else {
+				win.open(uri, null, features);
+			}
 		}
 		else {
 			var ww = Components.classes["@mozilla.org/embedcomp/window-watcher;1"]
diff --git a/chrome/content/zotero/preferences/preferences.xul b/chrome/content/zotero/preferences/preferences.xul
index d73f0ad6d..2058aca63 100644
--- a/chrome/content/zotero/preferences/preferences.xul
+++ b/chrome/content/zotero/preferences/preferences.xul
@@ -800,9 +800,9 @@ To add a new preference:
 		<groupbox>
 			<caption label="&zotero.preferences.miscellaneous;"/>
 			<hbox align="center">
-				<button id="openAboutConfig" label="&zotero.preferences.openAboutConfig;" oncommand="openInViewer('about:config', '')"/>
-				<button id="openCSLEdit" label="&zotero.preferences.openCSLEdit;" oncommand="openInViewer('chrome://zotero/content/tools/csledit.xul', '')"/>
-				<button id="openCSLPreview" label="&zotero.preferences.openCSLPreview;" oncommand="openInViewer('chrome://zotero/content/tools/cslpreview.xul', '')"/>
+				<button id="openAboutConfig" label="&zotero.preferences.openAboutConfig;" oncommand="openInViewer('about:config')"/>
+				<button id="openCSLEdit" label="&zotero.preferences.openCSLEdit;" oncommand="openInViewer('chrome://zotero/content/tools/csledit.xul', true)"/>
+				<button id="openCSLPreview" label="&zotero.preferences.openCSLPreview;" oncommand="openInViewer('chrome://zotero/content/tools/cslpreview.xul', true)"/>
 			</hbox>
 		</groupbox>
 		

From 814b15c23a9db8437b1057ed83f404217d0e9592 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Thu, 8 Mar 2012 14:47:29 -0500
Subject: [PATCH 07/37] Don't let translators try to load the current document
 a second time

---
 chrome/content/zotero/xpcom/utilities_translate.js | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/chrome/content/zotero/xpcom/utilities_translate.js b/chrome/content/zotero/xpcom/utilities_translate.js
index a80b48b49..5a7935f74 100644
--- a/chrome/content/zotero/xpcom/utilities_translate.js
+++ b/chrome/content/zotero/xpcom/utilities_translate.js
@@ -241,6 +241,17 @@ Zotero.Utilities.Translate.prototype.processDocuments = function(urls, processor
 		}
 	}
 	
+	for(var i=0; i<urls.length; i++) {
+		if("document" in this._translate && "location" in this._translate.document
+				&& this._translate.document.location.toString() === urls[i]) {
+			// Document is attempting to reload itself
+			Zotero.debug("Translate: Attempted to load the current document using processDocuments; using loaded document instead");
+			processor(this._translate.document, urls[i]);
+			urls.splice(i, 1);
+			i--;
+		}
+	}
+	
 	translate.incrementAsyncProcesses("Zotero.Utilities.Translate#processDocuments");
 	var hiddenBrowser = Zotero.HTTP.processDocuments(urls, function(doc) {
 		if(!processor) return;

From beb77864cb9f002b3950301ac730a9cc428b58de Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Thu, 8 Mar 2012 22:45:20 -0500
Subject: [PATCH 08/37] Don't clean periods when useComma is enabled

---
 chrome/content/zotero/xpcom/utilities.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index 15f514015..c55960664 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -147,7 +147,7 @@ Zotero.Utilities = {
 		}
 		
 		author = author.replace(/^[\s\.\,\/\[\]\:]+/, '');
-		author = author.replace(/[\s\,\/\[\]\:\.]+$/, '');
+		author = author.replace((useComma ? /[\s\,\/\[\]\:]+$/ : /[\s\,\/\[\]\:\.]+$/), '');
 		author = author.replace(/  +/, ' ');
 		if(useComma) {
 			// Add spaces between periods

From 998d52ec6d5ac22081217303c987a45ae961c9fd Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Thu, 8 Mar 2012 22:23:07 -0600
Subject: [PATCH 09/37] Place periods after all initials in first name

---
 chrome/content/zotero/xpcom/utilities.js | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index c55960664..15c91abf4 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -176,7 +176,23 @@ Zotero.Utilities = {
 			}
 			firstName = newFirstName.substr(1);
 		}
-		
+
+		//add periods after all the initials
+		if(firstName) {
+			var names = firstName.replace(/^[\s\.]+/,'')
+						.replace(/[\s\,]+$/,'')
+						//remove spaces surronding any dashes
+						.replace(/\s*([\u002D\u00AD\u2010-\u2015\u2212\u2E3A\u2E3B])\s*/,'$1')
+						.split(/[\s\.]+/);
+			var newFirstName = '';
+			for(var i=0, n=names.length; i<n; n++) {
+				newFirstName += names[i];
+				if(names[i].length == 1) newFirstName += '.';
+				newFirstName += ' ';
+			}
+			firstName = newFirstName.trim();
+		}
+
 		return {firstName:firstName, lastName:lastName, creatorType:type};
 	},
 	

From b23632f6c3338550735336c6831e86a1b16a381b Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Thu, 8 Mar 2012 22:26:33 -0600
Subject: [PATCH 10/37] Revert previous fix

---
 chrome/content/zotero/xpcom/utilities.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index 15c91abf4..279fd4c59 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -147,7 +147,7 @@ Zotero.Utilities = {
 		}
 		
 		author = author.replace(/^[\s\.\,\/\[\]\:]+/, '');
-		author = author.replace((useComma ? /[\s\,\/\[\]\:]+$/ : /[\s\,\/\[\]\:\.]+$/), '');
+		author = author.replace(/[\s\,\/\[\]\:\.]+$/, '');
 		author = author.replace(/  +/, ' ');
 		if(useComma) {
 			// Add spaces between periods

From 63c4096a6cd7601ecee169590d828d3288899ca0 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Fri, 9 Mar 2012 20:24:28 -0500
Subject: [PATCH 11/37] Specify both -moz-border-radius and border-radius.

Closes #66, Quick Format is square on nightly
---
 chrome/content/zotero-platform/mac/integration.css    | 1 +
 chrome/content/zotero-platform/win/integration.css    | 1 +
 chrome/skin/default/zotero/bindings/attachmentbox.css | 1 +
 chrome/skin/default/zotero/bindings/itembox.css       | 1 +
 chrome/skin/default/zotero/bindings/noteeditor.css    | 1 +
 chrome/skin/default/zotero/integration.css            | 2 ++
 chrome/skin/default/zotero/zotero.css                 | 1 +
 7 files changed, 8 insertions(+)

diff --git a/chrome/content/zotero-platform/mac/integration.css b/chrome/content/zotero-platform/mac/integration.css
index 34f1a8de4..ba257b723 100644
--- a/chrome/content/zotero-platform/mac/integration.css
+++ b/chrome/content/zotero-platform/mac/integration.css
@@ -31,6 +31,7 @@ body[multiline="true"] {
 #quick-format-entry {
 	background: -moz-linear-gradient(-90deg, rgb(243,123,119) 0, rgb(180,47,38) 50%, rgb(156,36,27) 50%);
 	-moz-border-radius:15px;
+	border-radius:15px;
 	padding: 10px;
 }
 
diff --git a/chrome/content/zotero-platform/win/integration.css b/chrome/content/zotero-platform/win/integration.css
index 38432c6c1..05bb899e8 100644
--- a/chrome/content/zotero-platform/win/integration.css
+++ b/chrome/content/zotero-platform/win/integration.css
@@ -28,6 +28,7 @@
 
 #quick-format-entry:not([square="true"]) {
 	-moz-border-radius: 15px;
+	border-radius: 15px;
 }
 
 #zotero-icon {
diff --git a/chrome/skin/default/zotero/bindings/attachmentbox.css b/chrome/skin/default/zotero/bindings/attachmentbox.css
index 802d8afbe..0c5b44fcf 100644
--- a/chrome/skin/default/zotero/bindings/attachmentbox.css
+++ b/chrome/skin/default/zotero/bindings/attachmentbox.css
@@ -59,6 +59,7 @@ row > label, row > hbox
 	-moz-margin-end: 5px !important;
 	padding: 0 2px 0 2px !important;
 	-moz-border-radius: 6px;
+	border-radius: 6px;
 	border: 1px solid transparent;
 }
 
diff --git a/chrome/skin/default/zotero/bindings/itembox.css b/chrome/skin/default/zotero/bindings/itembox.css
index 511bedb39..aa608e7e9 100644
--- a/chrome/skin/default/zotero/bindings/itembox.css
+++ b/chrome/skin/default/zotero/bindings/itembox.css
@@ -153,6 +153,7 @@ hbox.zotero-date-field-status > label
 	background-position: center !important;
 	border-width: 0 !important;
 	-moz-border-radius: 4px !important;
+	border-radius: 4px !important;
 }
 
 /* Merge pane in duplicates view */
diff --git a/chrome/skin/default/zotero/bindings/noteeditor.css b/chrome/skin/default/zotero/bindings/noteeditor.css
index 329e17221..49d0a4ece 100644
--- a/chrome/skin/default/zotero/bindings/noteeditor.css
+++ b/chrome/skin/default/zotero/bindings/noteeditor.css
@@ -24,6 +24,7 @@ row > label, row > hbox
 	-moz-margin-end: 5px !important;
 	padding: 0 2px 0 2px !important;
 	-moz-border-radius: 6px;
+	border-radius: 6px;
 	border: 1px solid transparent;
 }
 
diff --git a/chrome/skin/default/zotero/integration.css b/chrome/skin/default/zotero/integration.css
index cdf3c8c8b..931a4aa36 100644
--- a/chrome/skin/default/zotero/integration.css
+++ b/chrome/skin/default/zotero/integration.css
@@ -108,6 +108,7 @@
 
 .quick-format-bubble {
 	-moz-border-radius: 8px;
+	border-radius: 8px;
 	background-color: #dee7f8;
 	border-style: solid;
 	border-width: 1px;
@@ -124,6 +125,7 @@
 
 .quick-format-bubble[selected="true"] {
 	-moz-border-radius: 8px !important;
+	border-radius: 8px !important;
 	background-color: #598bec;
 	color: #fff;
 }
diff --git a/chrome/skin/default/zotero/zotero.css b/chrome/skin/default/zotero/zotero.css
index 891eb6386..966b94830 100644
--- a/chrome/skin/default/zotero/zotero.css
+++ b/chrome/skin/default/zotero/zotero.css
@@ -160,6 +160,7 @@ label.zotero-text-link {
 .zotero-clicky
 {	
 	-moz-border-radius: 6px;
+	border-radius: 6px;
 	border: 1px solid transparent;
 }
 

From 4e29a821b7aaea3aae4b1de3ada089610f8079d7 Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Fri, 9 Mar 2012 19:38:00 -0600
Subject: [PATCH 12/37] Fixed typo

---
 chrome/content/zotero/xpcom/utilities.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index 279fd4c59..e5883a137 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -185,7 +185,7 @@ Zotero.Utilities = {
 						.replace(/\s*([\u002D\u00AD\u2010-\u2015\u2212\u2E3A\u2E3B])\s*/,'$1')
 						.split(/[\s\.]+/);
 			var newFirstName = '';
-			for(var i=0, n=names.length; i<n; n++) {
+			for(var i=0, n=names.length; i<n; i++) {
 				newFirstName += names[i];
 				if(names[i].length == 1) newFirstName += '.';
 				newFirstName += ' ';

From 828d10a3967ccfaf5298137d86d26097a0601d6c Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Fri, 9 Mar 2012 20:00:21 -0600
Subject: [PATCH 13/37] Sort in _sanitizeItem instead of _compare

---
 .../zotero/tools/testTranslators/translatorTester.js     | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/chrome/content/zotero/tools/testTranslators/translatorTester.js b/chrome/content/zotero/tools/testTranslators/translatorTester.js
index 29a7a0814..ff0919873 100644
--- a/chrome/content/zotero/tools/testTranslators/translatorTester.js
+++ b/chrome/content/zotero/tools/testTranslators/translatorTester.js
@@ -220,7 +220,12 @@ Zotero_TranslatorTester._sanitizeItem = function(item, forSave) {
 	const skipFields = ["note", "notes", "itemID", "attachments", "tags", "seeAlso",
 						"itemType", "complete", "creators"];
 	for(var field in item) {
-		if(skipFields.indexOf(field) !== -1) continue;
+		if(skipFields.indexOf(field) !== -1) {
+			if(field == 'tags') {
+				item[field].sort();
+			}
+			continue;
+		}
 		
 		if(!item[field] || !(fieldID = Zotero.ItemFields.getID(field))) {
 			delete item[field];
@@ -574,8 +579,6 @@ Zotero_TranslatorTester.prototype._compare = function(i, j) {
 	var match = false;
 	if (Object.prototype.toString.apply(i) === '[object Array]') {
 		if (Object.prototype.toString.apply(j) === '[object Array]') {
-			i.sort();
-			j.sort();
 			do {
 				match = this._compare(i.pop(), j.pop());
 			} while (match && i.length && j.length);

From 67dac4ec0d3c8377ae527e5db971c8820a713769 Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Sat, 10 Mar 2012 03:07:45 -0600
Subject: [PATCH 14/37] Moved tag sorting to a later point.

---
 .../zotero/tools/testTranslators/translatorTester.js        | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/chrome/content/zotero/tools/testTranslators/translatorTester.js b/chrome/content/zotero/tools/testTranslators/translatorTester.js
index ff0919873..1a05d837b 100644
--- a/chrome/content/zotero/tools/testTranslators/translatorTester.js
+++ b/chrome/content/zotero/tools/testTranslators/translatorTester.js
@@ -221,9 +221,6 @@ Zotero_TranslatorTester._sanitizeItem = function(item, forSave) {
 						"itemType", "complete", "creators"];
 	for(var field in item) {
 		if(skipFields.indexOf(field) !== -1) {
-			if(field == 'tags') {
-				item[field].sort();
-			}
 			continue;
 		}
 		
@@ -246,6 +243,9 @@ Zotero_TranslatorTester._sanitizeItem = function(item, forSave) {
 	
 	// remove fields to be ignored
 	if("accessDate" in item) delete item.accessDate;
+
+	//sort tags, if they're still there
+	if(item.tags) item.tags.sort();
 	
 	return item;
 };

From 1050fc32b3d8eb0d6cfb25092b47780ec2de5c6f Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Sun, 11 Mar 2012 16:03:00 -0400
Subject: [PATCH 15/37] Fix dropping of empty creators

---
 chrome/content/zotero/xpcom/utilities.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index e5883a137..b7e7b7f75 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -1115,7 +1115,7 @@ Zotero.Utilities = {
 			} else if(field === "creators") {
 				// normalize creators
 				var n = val.length;
-				var newCreators = newItem.creators = new Array(n);
+				var newCreators = newItem.creators = [];
 				for(var j=0; j<n; j++) {
 					var creator = val[j];
 					
@@ -1148,7 +1148,7 @@ Zotero.Utilities = {
 					}
 					if(!newCreator.creatorType) newCreator.creatorType = "author";
 					
-					newCreators[j] = newCreator;
+					newCreators.push(newCreator);
 				}
 			} else if(field === "tags") {
 				// normalize tags

From 25d48fbca7d4530278661cf80358e1b165c555df Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Sun, 11 Mar 2012 16:03:26 -0400
Subject: [PATCH 16/37] Get first 100 tickets (TODO: get multiple pages)

---
 chrome/content/zotero/tools/testTranslators/testTranslators.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/tools/testTranslators/testTranslators.js b/chrome/content/zotero/tools/testTranslators/testTranslators.js
index ed1c00d4d..fedc1ef26 100644
--- a/chrome/content/zotero/tools/testTranslators/testTranslators.js
+++ b/chrome/content/zotero/tools/testTranslators/testTranslators.js
@@ -70,7 +70,7 @@ var Issues = new function() {
 	};
 	
 	var req = new XMLHttpRequest();
-	req.open("GET", "https://api.github.com/repos/zotero/translators/issues", true);
+	req.open("GET", "https://api.github.com/repos/zotero/translators/issues?per_page=100", true);
 	req.onreadystatechange = function(e) {
 		if(req.readyState != 4) return;
 		

From e1113209d5a04b96d8cc4847ac4cbea1fa289bc7 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Sun, 11 Mar 2012 16:25:47 -0400
Subject: [PATCH 17/37] Disable unresponsive script warning before delayed
 bundled files update

---
 chrome/content/zotero/xpcom/schema.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/schema.js b/chrome/content/zotero/xpcom/schema.js
index 60bef8d9c..3373f6d70 100644
--- a/chrome/content/zotero/xpcom/schema.js
+++ b/chrome/content/zotero/xpcom/schema.js
@@ -212,7 +212,13 @@ Zotero.Schema = new function(){
 		
 		// After a delay, start update of bundled files and repo updates
 		setTimeout(function () {
-			var up = Zotero.Schema.updateBundledFiles();
+			try {
+				Zotero.UnresponsiveScriptIndicator.disable();
+				var up = Zotero.Schema.updateBundledFiles();
+			}
+			finally {
+				Zotero.UnresponsiveScriptIndicator.enable();
+			}
 			if (up) {
 				// Run a manual scraper update if upgraded and pref set
 				if (Zotero.Prefs.get('automaticScraperUpdates')) {

From 9821db988dce9ea8da512027983a855b35636ef7 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Sun, 11 Mar 2012 18:36:54 -0400
Subject: [PATCH 18/37] Fix "_observers.get(i).ref is undefined) errors

If a notifier observer caused another observer to be deleted, an error
would occur.
---
 chrome/content/zotero/xpcom/notifier.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/chrome/content/zotero/xpcom/notifier.js b/chrome/content/zotero/xpcom/notifier.js
index 713fc41ca..01cda4965 100644
--- a/chrome/content/zotero/xpcom/notifier.js
+++ b/chrome/content/zotero/xpcom/notifier.js
@@ -145,6 +145,12 @@ Zotero.Notifier = new function(){
 		
 		for (var i in _observers.items){
 			Zotero.debug("Calling notify('" + event + "') on observer with hash '" + i + "'", 4);
+			
+			if (!_observers.get(i)) {
+				Zotero.debug("Observer no longer exists");
+				continue;
+			}
+			
 			// Find observers that handle notifications for this type (or all types)
 			if (!_observers.get(i).types || _observers.get(i).types.indexOf(type)!=-1){
 				// Catch exceptions so all observers get notified even if

From 5e190204376d1a1f75d550925d83407d9bf0dd9b Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Sun, 11 Mar 2012 18:54:46 -0400
Subject: [PATCH 19/37] Auto-empty items from trash on idle rather than at pane
 open

Deleting is currently very slow (which will be fixed on master), which
can cause long delays when auto-emptying items older at pane open.
Instead, empty 10 items after 5 minutes of idle, and then another 10
every 5 seconds until there are no more items to empty or the user is back.
---
 chrome/content/zotero/xpcom/data/items.js | 67 ++++++++++++++++++++++-
 chrome/content/zotero/xpcom/zotero.js     |  2 +
 chrome/content/zotero/zoteroPane.js       | 10 ----
 3 files changed, 67 insertions(+), 12 deletions(-)

diff --git a/chrome/content/zotero/xpcom/data/items.js b/chrome/content/zotero/xpcom/data/items.js
index 748bafe85..58b38e297 100644
--- a/chrome/content/zotero/xpcom/data/items.js
+++ b/chrome/content/zotero/xpcom/data/items.js
@@ -62,6 +62,8 @@ Zotero.Items = new function() {
 	var _cachedFields = [];
 	var _firstCreatorSQL = '';
 	var _primaryFields = [];
+	var _emptyTrashIdleObserver = null;
+	var _emptyTrashTimer = null;
 	
 	
 	/*
@@ -490,18 +492,79 @@ Zotero.Items = new function() {
 	/**
 	 * @param	{Integer}	days	Only delete items deleted more than this many days ago
 	 */
-	this.emptyTrash = function (libraryID, days) {
+	this.emptyTrash = function (libraryID, days, limit) {
 		Zotero.DB.beginTransaction();
 		var deletedIDs = this.getDeleted(libraryID, true, days);
 		if (deletedIDs.length) {
+			if (limit) {
+				deletedIDs = deletedIDs.slice(0, limit - 1)
+			}
 			this.erase(deletedIDs);
-			Zotero.Notifier.trigger('refresh', 'collection', libraryID ? libraryID : 0);
+			Zotero.Notifier.trigger('refresh', 'trash', libraryID ? libraryID : 0);
 		}
 		Zotero.DB.commitTransaction();
 		return deletedIDs.length;
 	}
 	
 	
+	/**
+	 * Start idle observer to delete trashed items older than a certain number of days
+	 */
+	this.startEmptyTrashTimer = function () {
+		_emptyTrashIdleObserver = {
+			observe: function (subject, topic, data) {
+				if (topic == 'idle' || topic == 'timer-callback') {
+					var days = Zotero.Prefs.get('trashAutoEmptyDays');
+					if (!days) {
+						return;
+					}
+					
+					// TODO: empty group trashes if permissions
+					
+					var d = new Date();
+					
+					// Delete a few items a time
+					//
+					// TODO: increase number after dealing with slow
+					// tag.getLinkedItems() call during deletes
+					Zotero.debug("Auto-emptying items from trash");
+					var num = 10;
+					var deleted = Zotero.Items.emptyTrash(null, days, num);
+					
+					var d2 = new Date();
+					Zotero.debug("Emptied " + deleted + " old items from trash in " + (d2 - d) + " ms");
+					
+					if (!deleted) {
+						_emptyTrashTimer = null;
+						return;
+					}
+					
+					// Set a timer to do more every few seconds
+					if (!_emptyTrashTimer) {
+						_emptyTrashTimer = Components.classes["@mozilla.org/timer;1"].
+											createInstance(Components.interfaces.nsITimer);
+					}
+					_emptyTrashTimer.init(
+						_emptyTrashIdleObserver.observe,
+						5 * 1000,
+						Components.interfaces.nsITimer.TYPE_ONE_SHOT
+					);
+				}
+				// When no longer idle, cancel timer
+				else if (topic == 'back') {
+					if (_emptyTrashTimer) {
+						_emptyTrashTimer.cancel();
+					}
+				}
+			}
+		};
+		
+		var idleService = Components.classes["@mozilla.org/widget/idleservice;1"].
+							getService(Components.interfaces.nsIIdleService);
+		idleService.addIdleObserver(_emptyTrashIdleObserver, 305);
+	}
+	
+	
 	/**
 	 * Delete item(s) from database and clear from internal array
 	 *
diff --git a/chrome/content/zotero/xpcom/zotero.js b/chrome/content/zotero/xpcom/zotero.js
index 540bdfea4..35ecf05f3 100644
--- a/chrome/content/zotero/xpcom/zotero.js
+++ b/chrome/content/zotero/xpcom/zotero.js
@@ -669,6 +669,8 @@ const ZOTERO_CONFIG = {
 		// Initialize Locate Manager
 		Zotero.LocateManager.init();
 		
+		Zotero.Items.startEmptyTrashTimer();
+		
 		return true;
 	}
 	
diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js
index 157178cbe..ad6615738 100644
--- a/chrome/content/zotero/zoteroPane.js
+++ b/chrome/content/zotero/zoteroPane.js
@@ -403,16 +403,6 @@ var ZoteroPane = new function()
 			searchBar.inputField.select();
 		}, 1);
 		
-		// Auto-empty trashed items older than a certain number of days
-		var days = Zotero.Prefs.get('trashAutoEmptyDays');
-		if (days) {
-			var d = new Date();
-			// TODO: empty group trashes if permissions
-			var deleted = Zotero.Items.emptyTrash(null, days);
-			var d2 = new Date();
-			Zotero.debug("Emptied old items from trash in " + (d2 - d) + " ms");
-		}
-		
 		var d = new Date();
 		Zotero.purgeDataObjects();
 		var d2 = new Date();

From ea7094821a76a8080a1bb21164a24088cc01ff7d Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Sun, 11 Mar 2012 19:37:01 -0400
Subject: [PATCH 20/37] Don't block when calling fallbackLauncher

---
 chrome/content/zotero/zoteroPane.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js
index ad6615738..343998364 100644
--- a/chrome/content/zotero/zoteroPane.js
+++ b/chrome/content/zotero/zoteroPane.js
@@ -3506,10 +3506,10 @@ var ZoteroPane = new function()
 			
 			var args = [url];
 			if (!Zotero.isFx36) {
-				proc.runw(true, args, args.length);
+				proc.runw(false, args, args.length);
 			}
 			else {
-				proc.run(true, args, args.length);
+				proc.run(false, args, args.length);
 			}
 		}
 	}

From 90b515732b3b26262da61f2a2a91e95dc6c75269 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Sun, 11 Mar 2012 23:01:43 -0400
Subject: [PATCH 21/37] Try alternative strategy for activating windows

---
 chrome/content/zotero/xpcom/integration.js | 212 +++++++++++++--------
 1 file changed, 130 insertions(+), 82 deletions(-)

diff --git a/chrome/content/zotero/xpcom/integration.js b/chrome/content/zotero/xpcom/integration.js
index 87840ce8c..77661dacf 100644
--- a/chrome/content/zotero/xpcom/integration.js
+++ b/chrome/content/zotero/xpcom/integration.js
@@ -52,11 +52,11 @@ Zotero.Integration = new function() {
 	// these need to be global because of GC
 	var _updateTimer;
 	
-	// For Carbon and X11
-	var _carbon, ProcessSerialNumber, SetFrontProcessWithOptions,
-		_x11, _x11Display, XClientMessageEvent, XFetchName, XFree, XQueryTree, XOpenDisplay,
-		XCloseDisplay, XFlush, XDefaultRootWindow, XInternAtom, XSendEvent, XMapRaised,
-		XGetWindowProperty;
+	// For Carbon
+	var _carbon, ProcessSerialNumber, SetFrontProcessWithOptions;
+	var _x11, _x11Display, _x11RootWindow, XClientMessageEvent, XFetchName, XFree, XQueryTree,
+		XOpenDisplay, XCloseDisplay, XFlush, XDefaultRootWindow, XInternAtom, XSendEvent,
+		XMapRaised, XGetWindowProperty, X11Atom, X11Bool, X11Display, X11Window, X11Status;
 	
 	var _inProgress = false;
 	this.currentWindow = false;
@@ -360,11 +360,11 @@ Zotero.Integration = new function() {
 					}
 				}
 				
-				const Status = ctypes.int,
-					Display = new ctypes.StructType("Display"),
-					Window = ctypes.unsigned_long,
-					Atom = ctypes.unsigned_long,
-					Bool = ctypes.int;
+				X11Atom = ctypes.unsigned_long;
+				X11Bool = ctypes.int;
+				X11Display = new ctypes.StructType("Display");
+				X11Window = ctypes.unsigned_long;
+				X11Status = ctypes.int;
 					
 				/*
 				 * typedef struct {
@@ -386,10 +386,10 @@ Zotero.Integration = new function() {
 					[
 						{"type":ctypes.int},
 						{"serial":ctypes.unsigned_long},
-						{"send_event":Bool},
-						{"display":Display.ptr},
-						{"window":Window},
-						{"message_type":Atom},
+						{"send_event":X11Bool},
+						{"display":X11Display.ptr},
+						{"window":X11Window},
+						{"message_type":X11Atom},
 						{"format":ctypes.int},
 						{"l0":ctypes.long},
 						{"l1":ctypes.long},
@@ -406,8 +406,8 @@ Zotero.Integration = new function() {
 				 *    char**		window_name_return
 				 * );
 				 */
-				XFetchName = _x11.declare("XFetchName", ctypes.default_abi, Status, Display.ptr,
-					Window, ctypes.char.ptr.ptr);
+				XFetchName = _x11.declare("XFetchName", ctypes.default_abi, X11Status,
+					X11Display.ptr, X11Window, ctypes.char.ptr.ptr);
 					
 				/*
 				 * Status XQueryTree(
@@ -419,8 +419,9 @@ Zotero.Integration = new function() {
 				 *    unsigned int*	nchildren_return
 				 * );
 				 */
-				XQueryTree = _x11.declare("XQueryTree", ctypes.default_abi, Status, Display.ptr,
-					Window, Window.ptr, Window.ptr, Window.ptr.ptr, ctypes.unsigned_int.ptr);
+				XQueryTree = _x11.declare("XQueryTree", ctypes.default_abi, X11Status,
+					X11Display.ptr, X11Window, X11Window.ptr, X11Window.ptr, X11Window.ptr.ptr,
+					ctypes.unsigned_int.ptr);
 				
 				/*
 				 * int XFree(
@@ -434,7 +435,7 @@ Zotero.Integration = new function() {
 				 *     _Xconst char*	display_name
 				 * );
 				 */
-				XOpenDisplay = _x11.declare("XOpenDisplay", ctypes.default_abi, Display.ptr,
+				XOpenDisplay = _x11.declare("XOpenDisplay", ctypes.default_abi, X11Display.ptr,
 				 	ctypes.char.ptr);
 				 
 				/*
@@ -443,14 +444,14 @@ Zotero.Integration = new function() {
 				 * );
 				 */
 				XCloseDisplay = _x11.declare("XCloseDisplay", ctypes.default_abi, ctypes.int,
-					Display.ptr);
+					X11Display.ptr);
 				
 				/*
 				 * int XFlush(
 				 *     Display*		display
 				 * );
 				 */
-				XFlush = _x11.declare("XFlush", ctypes.default_abi, ctypes.int, Display.ptr);
+				XFlush = _x11.declare("XFlush", ctypes.default_abi, ctypes.int, X11Display.ptr);
 				
 				/*
 				 * Window XDefaultRootWindow(
@@ -458,7 +459,7 @@ Zotero.Integration = new function() {
 				 * );
 				 */
 				XDefaultRootWindow = _x11.declare("XDefaultRootWindow", ctypes.default_abi,
-					Window, Display.ptr);
+					X11Window, X11Display.ptr);
 					
 				/*
 				 * Atom XInternAtom(
@@ -467,8 +468,8 @@ Zotero.Integration = new function() {
 				 *     Bool				only_if_exists
 				 * );
 				 */
-				XInternAtom = _x11.declare("XInternAtom", ctypes.default_abi, Atom, Display.ptr,
-				 	ctypes.char.ptr, Bool);
+				XInternAtom = _x11.declare("XInternAtom", ctypes.default_abi, X11Atom,
+					X11Display.ptr, ctypes.char.ptr, X11Bool);
 				 
 				/*
 				 * Status XSendEvent(
@@ -479,8 +480,8 @@ Zotero.Integration = new function() {
 				 *     XEvent*		event_send
 				 * );
 				 */
-				XSendEvent = _x11.declare("XSendEvent", ctypes.default_abi, Status, Display.ptr,
-				 	Window, Bool, ctypes.long, XClientMessageEvent.ptr);
+				XSendEvent = _x11.declare("XSendEvent", ctypes.default_abi, X11Status,
+					X11Display.ptr, X11Window, X11Bool, ctypes.long, XClientMessageEvent.ptr);
 				
 				/*
 				 * int XMapRaised(
@@ -488,89 +489,136 @@ Zotero.Integration = new function() {
 				 *     Window		w
 				 * );
 				 */
-				XMapRaised = _x11.declare("XMapRaised", ctypes.default_abi, ctypes.int, Display.ptr,
-				 	Window);
+				XMapRaised = _x11.declare("XMapRaised", ctypes.default_abi, ctypes.int,
+					X11Display.ptr, X11Window);
+				
+				/*
+				 * extern int XGetWindowProperty(
+				 *     Display*		 display,
+				 *     Window		 w,
+				 *     Atom		 property,
+				 *     long		 long_offset,
+				 *     long		 long_length,
+				 *     Bool		 delete,
+				 *     Atom		 req_type,
+				 *     Atom*		 actual_type_return,
+				 *     int*		 actual_format_return,
+				 *     unsigned long*	 nitems_return,
+				 *     unsigned long*	 bytes_after_return,
+				 *     unsigned char**	 prop_return 
+				 * );
+				 */
+				XGetWindowProperty = _x11.declare("XGetWindowProperty", ctypes.default_abi,
+					ctypes.int, X11Display.ptr, X11Window, X11Atom, ctypes.long, ctypes.long,
+					X11Bool, X11Atom, X11Atom.ptr, ctypes.int.ptr, ctypes.unsigned_long.ptr,
+					ctypes.unsigned_long.ptr, ctypes.char.ptr.ptr);
 				
 				 	
 				_x11Display = XOpenDisplay(null);
 				if(!_x11Display) {
 					Zotero.debug("Integration: Could not open display; not activating");
 					_x11 = false;
+					return;
 				}
 				
 				Zotero.addShutdownListener(function() {
 					XCloseDisplay(_x11Display);
 				});
-			}
-	
-			var rootWindow = XDefaultRootWindow(_x11Display),
-				intervalID;
-			
-			function _X11BringToForeground() {
-				var windowTitle = win.QueryInterface(Ci.nsIInterfaceRequestor)
-					.getInterface(Ci.nsIWebNavigation).QueryInterface(Ci.nsIBaseWindow).title;
 				
-				var x11Window = _X11FindWindow(_x11Display, rootWindow, windowTitle);
-				if(!x11Window) return;
-				win.clearInterval(intervalID);
-					
-				var event = new XClientMessageEvent();
-				event.type = 33; /* ClientMessage*/
-				event.serial = 0;
-				event.send_event = 1;
-				event.message_type = XInternAtom(_x11Display, "_NET_ACTIVE_WINDOW", 0);
-				event.display = _x11Display;
-				event.window = x11Window;
-				event.format = 32;
-				event.l0 = 2;
-				var mask = 1<<20 /* SubstructureRedirectMask */ | 1<<19 /* SubstructureNotifyMask */;
-				
-				if(XSendEvent(_x11Display, rootWindow, 0, mask, event.address())) {
-					XMapRaised(_x11Display, x11Window);
-					XFlush(_x11Display);
-					Zotero.debug("Activated successfully");
-				} else {
-					Zotero.debug("Integration: An error occurred activating the window");
+				_x11RootWindow = XDefaultRootWindow(_x11Display);
+				if(!_x11RootWindow) {
+					Zotero.debug("Integration: Could not get root window; not activating");
+					_x11 = false;
+					return;
 				}
 			}
-			
+	
 			win.addEventListener("load", function() {
-				intervalID = win.setInterval(_X11BringToForeground, 50);
+				var intervalID;
+				intervalID = win.setInterval(function() {
+					_X11BringToForeground(win, intervalID);
+				}, 50);
 			}, false);
 		}
 	}
 	
-	function _X11FindWindow(display, w, searchName) {
+	/**
+	 * Get a property from an X11 window
+	 */
+	function _X11GetProperty(win, propertyName, propertyType) {
 		Components.utils.import("resource://gre/modules/ctypes.jsm");
 		
-		var childrenPtr = new ctypes.unsigned_long.ptr(),
-			dummy = new ctypes.unsigned_long(),
-			foundName = new ctypes.char.ptr(),
-			nChildren = new ctypes.unsigned_int();
-		
-		if(XFetchName(display, w, foundName.address())) {
-			var foundNameString = foundName.readString();
-			XFree(foundName);
-			if(foundNameString === searchName) return w;
+		var returnType = new X11Atom(),
+			returnFormat = new ctypes.int(),
+			nItemsReturned = new ctypes.unsigned_long(),
+			nBytesAfterReturn = new ctypes.unsigned_long(),
+			data = new ctypes.char.ptr();
+		if(!XGetWindowProperty(_x11Display, win, XInternAtom(_x11Display, propertyName, 0), 0, 1024,
+				0, propertyType, returnType.address(), returnFormat.address(),
+				nItemsReturned.address(), nBytesAfterReturn.address(), data.address())) {
+			var nElements = ctypes.cast(nItemsReturned, ctypes.unsigned_int).value;
+			if(nElements) return [data, nElements];
 		}
+		return null;
+	}
+	
+	/** 
+	 * Bring a window to the foreground by interfacing directly with X11
+	 */
+	function _X11BringToForeground(win, intervalID) {
+		var windowTitle = win.QueryInterface(Ci.nsIInterfaceRequestor)
+			.getInterface(Ci.nsIWebNavigation).QueryInterface(Ci.nsIBaseWindow).title;
 		
-		var dummyPtr = dummy.address();
-		if(!XQueryTree(display, w, dummyPtr, dummyPtr, childrenPtr.address(),
-				nChildren.address()) || childrenPtr.isNull()) {
-			return false;
+		var x11Window = _X11FindWindow(_x11RootWindow, windowTitle);
+		if(!x11Window) return;
+		win.clearInterval(intervalID);
+			
+		var event = new XClientMessageEvent();
+		event.type = 33; /* ClientMessage*/
+		event.serial = 0;
+		event.send_event = 1;
+		event.message_type = XInternAtom(_x11Display, "_NET_ACTIVE_WINDOW", 0);
+		event.display = _x11Display;
+		event.window = x11Window;
+		event.format = 32;
+		event.l0 = 2;
+		var mask = 1<<20 /* SubstructureRedirectMask */ | 1<<19 /* SubstructureNotifyMask */;
+		
+		if(XSendEvent(_x11Display, _x11RootWindow, 0, mask, event.address())) {
+			XMapRaised(_x11Display, x11Window);
+			XFlush(_x11Display);
+			Zotero.debug("Activated successfully");
+		} else {
+			Zotero.debug("Integration: An error occurred activating the window");
 		}
+	}
+	
+	/**
+	 * Find an X11 window given a name
+	 */
+	function _X11FindWindow(w, searchName) {
+		Components.utils.import("resource://gre/modules/ctypes.jsm");
 		
-		var nChildrenJS = nChildren.value;
-		var children = ctypes.cast(childrenPtr, ctypes.uint32_t.array(nChildrenJS).ptr).contents;
-		var foundWindow = false;
-		for(var i=0; i<nChildrenJS; i++) {
-			var testWin = children.addressOfElement(i).contents;
-			if(testWin == 0) continue;
-			foundWindow = _X11FindWindow(display, testWin, searchName);
-			if(foundWindow) break;
+		var res = _X11GetProperty(w, "_NET_CLIENT_LIST", 33 /** XA_WINDOW **/)
+			|| _X11GetProperty(w, "_WIN_CLIENT_LIST", 6 /** XA_CARDINAL **/);
+		if(!res) return false;
+		
+		var nClients = res[1],
+			clientList = ctypes.cast(res[0], X11Window.array(nClients).ptr).contents,
+			foundName = new ctypes.char.ptr();
+		for(var i=0; i<nClients; i++) {			
+			if(XFetchName(_x11Display, clientList.addressOfElement(i).contents,
+					foundName.address())) {
+				var foundNameString = undefined;
+				try {
+					foundNameString = foundName.readString();
+				} catch(e) {}
+				XFree(foundName);
+				if(foundNameString === searchName) return clientList.addressOfElement(i).contents;
+			}
 		}
+		XFree(res[0]);
 		
-		XFree(children);
 		return foundWindow;
 	}
 	

From 8b157709bd6b9fd36b584cb0afb4baac28baa261 Mon Sep 17 00:00:00 2001
From: Frank <biercenator@gmail.com>
Date: Thu, 1 Mar 2012 05:41:12 +0800
Subject: [PATCH 22/37] Upgrade citeproc-js to version 1.0.296

---
 chrome/content/zotero/xpcom/citeproc.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/citeproc.js b/chrome/content/zotero/xpcom/citeproc.js
index a4ac284c7..e1556558d 100644
--- a/chrome/content/zotero/xpcom/citeproc.js
+++ b/chrome/content/zotero/xpcom/citeproc.js
@@ -2153,7 +2153,7 @@ CSL.DateParser = function () {
 };
 CSL.Engine = function (sys, style, lang, forceLang) {
     var attrs, langspec, localexml, locale;
-    this.processor_version = "1.0.295";
+    this.processor_version = "1.0.296";
     this.csl_version = "1.0";
     this.sys = sys;
     this.sys.xml = new CSL.System.Xml.Parsing();
@@ -11730,6 +11730,7 @@ CSL.Disambiguation.prototype.disNames = function (ismax) {
         mybase.year_suffix = false;
         this.state.registry.registerAmbigToken(this.akey, "" + this.partners[0].id, mybase);
         this.state.registry.registerAmbigToken(this.akey, "" + this.nonpartners[0].id, mybase);
+        this.state.tmp.taintedItemIDs[this.nonpartners[0].id] = true;
         this.lists[this.listpos] = [this.base, []];
     } else if (this.clashes[1] === 0) {
         this.betterbase = CSL.cloneAmbigConfig(this.base);

From 74af1fbb8c3486491b20570b083f44bce23d62f7 Mon Sep 17 00:00:00 2001
From: Frank <biercenator@gmail.com>
Date: Fri, 2 Mar 2012 10:57:50 +0800
Subject: [PATCH 23/37] Upgrade citeproc-js to version 1.0.297

---
 chrome/content/zotero/xpcom/citeproc.js | 31 ++++++++++++++-----------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/chrome/content/zotero/xpcom/citeproc.js b/chrome/content/zotero/xpcom/citeproc.js
index e1556558d..b7d994f22 100644
--- a/chrome/content/zotero/xpcom/citeproc.js
+++ b/chrome/content/zotero/xpcom/citeproc.js
@@ -2153,7 +2153,7 @@ CSL.DateParser = function () {
 };
 CSL.Engine = function (sys, style, lang, forceLang) {
     var attrs, langspec, localexml, locale;
-    this.processor_version = "1.0.296";
+    this.processor_version = "1.0.297";
     this.csl_version = "1.0";
     this.sys = sys;
     this.sys.xml = new CSL.System.Xml.Parsing();
@@ -2163,6 +2163,7 @@ CSL.Engine = function (sys, style, lang, forceLang) {
     if (CSL.getAbbreviation) {
         this.sys.getAbbreviation = CSL.getAbbreviation;
     }
+    this.sys.AbbreviationSegments = CSL.AbbreviationSegments;
     this.parallel = new CSL.Parallel(this);
     this.transform = new CSL.Transform(this);
     this.setParseNames = function (val) {
@@ -2337,10 +2338,12 @@ CSL.Engine.prototype.getTerm = function (term, form, plural, gender, mode) {
     if (!ret && term === "range-delimiter") {
         ret = "\u2013";
     }
-    if (typeof ret === "undefined" && mode === CSL.STRICT) {
-        throw "Error in getTerm: term \"" + term + "\" does not exist.";
-    } else if (mode === CSL.TOLERANT) {
-        ret = false;
+    if (typeof ret === "undefined") {
+        if (mode === CSL.STRICT) {
+            throw "Error in getTerm: term \"" + term + "\" does not exist.";
+        } else if (mode === CSL.TOLERANT) {
+            ret = "";
+        }
     }
     if (ret) {
         this.tmp.cite_renders_content = true;
@@ -5465,7 +5468,7 @@ CSL.NameOutput.prototype._buildLabel = function (term, plural, position) {
     var ret = false;
     var node = this.label[position];
     if (node) {
-        ret = CSL.castLabel(this.state, node, term, plural);
+        ret = CSL.castLabel(this.state, node, term, plural, CSL.TOLERANT);
     }
     return ret;
 };
@@ -6836,7 +6839,7 @@ CSL.evaluateLabel = function (node, state, Item, item) {
             plural = state.tmp.shadow_numbers[myterm].plural;
         }
     }
-    return CSL.castLabel(state, node, myterm, plural);
+    return CSL.castLabel(state, node, myterm, plural, CSL.TOLERANT);
 };
 CSL.evaluateStringPluralism = function (str) {
     if (str) {
@@ -7594,15 +7597,15 @@ CSL.Node.text = {
                                 }
                             };
                         } else if (this.variables_real[0] === "hereinafter") {
-                            if (state.sys.getAbbreviation) {
-                                func = function (state, Item) {
-                                    var hereinafter_info = state.transform.getHereinafter(Item);
+                            func = function (state, Item) {
+                                var hereinafter_info = state.transform.getHereinafter(Item);
+                                if (state.transform.abbrevs[hereinafter_info[0]]) {
                                     var value = state.transform.abbrevs[hereinafter_info[0]].hereinafter[hereinafter_info[1]];
                                     if (value) {
                                         state.tmp.group_context.value()[2] = true;
                                         state.output.append(value, this);
                                     }
-                                };
+                                }
                             }
                         } else if (this.variables_real[0] === "URL") {
                             func = function (state, Item) {
@@ -8622,7 +8625,7 @@ CSL.Util.Match = function () {
 CSL.Transform = function (state) {
     var debug = false, abbreviations, token, fieldname, abbrev_family, opt;
     this.abbrevs = {};
-    this.abbrevs["default"] = new CSL.AbbreviationSegments();
+    this.abbrevs["default"] = new state.sys.AbbreviationSegments();
     function init(mytoken, myfieldname, myabbrev_family) {
         token = mytoken;
         fieldname = myfieldname;
@@ -8721,7 +8724,7 @@ CSL.Transform = function (state) {
         }
         if (!orig) {
             if (!this.abbrevs[jurisdiction]) {
-                this.abbrevs[jurisdiction] = new CSL.AbbreviationSegments();
+                this.abbrevs[jurisdiction] = new state.sys..AbbreviationSegments();
             }
             return jurisdiction;
         }
@@ -8735,7 +8738,7 @@ CSL.Transform = function (state) {
             }
             for (var i=tryList.length - 1; i > -1; i += -1) {
                 if (!this.abbrevs[tryList[i]]) {
-                    this.abbrevs[tryList[i]] = new CSL.AbbreviationSegments();
+                    this.abbrevs[tryList[i]] = new state.sys.AbbreviationSegments();
                 }
                 if (!this.abbrevs[tryList[i]][category][orig]) {
                     state.sys.getAbbreviation(state.opt.styleID, this.abbrevs, tryList[i], category, orig);

From 25862e3af099ec1b71a60028263fae4723215918 Mon Sep 17 00:00:00 2001
From: Frank <biercenator@gmail.com>
Date: Tue, 6 Mar 2012 07:23:26 +0800
Subject: [PATCH 24/37] Update citeproc-js to version 1.0.298 (note that
 previous 1.0.295 tag update is mis-applied and anachronistic)

---
 chrome/content/zotero/xpcom/citeproc.js | 112 +++++-------------------
 1 file changed, 24 insertions(+), 88 deletions(-)

diff --git a/chrome/content/zotero/xpcom/citeproc.js b/chrome/content/zotero/xpcom/citeproc.js
index b7d994f22..64c80f734 100644
--- a/chrome/content/zotero/xpcom/citeproc.js
+++ b/chrome/content/zotero/xpcom/citeproc.js
@@ -2153,7 +2153,7 @@ CSL.DateParser = function () {
 };
 CSL.Engine = function (sys, style, lang, forceLang) {
     var attrs, langspec, localexml, locale;
-    this.processor_version = "1.0.297";
+    this.processor_version = "1.0.298";
     this.csl_version = "1.0";
     this.sys = sys;
     this.sys.xml = new CSL.System.Xml.Parsing();
@@ -5019,9 +5019,11 @@ CSL.Node.key = {
                     func = CSL.dateAsSortKey;
                     single_text.variables = this.variables;
                 } else if ("title" === variable) {
-                    state.transform.init("empty", "title");
-                    state.transform.setTransformFallback(true);
-                    func = state.transform.getOutputFunction(this.variables);
+                    var abbrevfam = "title";
+                    var abbrfall = false;
+                    var altvar = false;
+                    var transfall = true;
+                    func = state.transform.getOutputFunction(this.variables, abbrevfam, abbrfall, altvar, transfall);
                 } else {
                     func = function (state, Item) {
                         var varval = Item[variable];
@@ -7524,25 +7526,26 @@ CSL.Node.text = {
                     };
                     this.execs.push(func);
                     if (CSL.MULTI_FIELDS.indexOf(this.variables_real[0]) > -1) {
+                        var abbrevfam = this.variables[0];
+                        var abbrfall = false;
+                        var altvar = false;
+                        var transfall = false;
                         if (form === "short") {
-                            state.transform.init(this, this.variables_real[0], this.variables_real[0]);
                             if (this.variables_real[0] === "container-title") {
-                                state.transform.setAlternativeVariableName("journalAbbreviation");
+                                altvar = "journalAbbreviation";
                             } else if (this.variables_real[0] === "title") {
-                                state.transform.setAlternativeVariableName("shortTitle");
+                                altvar = "shortTitle";
                             }
                         } else {
-                            state.transform.init(this, this.variables_real[0]);
+                            abbrevfam = false;
                         }
                         if (state.build.extension) {
-                            state.transform.init(this, this.variables_real[0], this.variables_real[0]);
-                            state.transform.setTransformFallback(true);
-                            func = state.transform.getOutputFunction(this.variables);
+                            transfall = true;
                         } else {
-                            state.transform.setTransformFallback(true);
-                            state.transform.setAbbreviationFallback(true);
-                            func = state.transform.getOutputFunction(this.variables);
+                            transfall = true;
+                            abbrfall = true;
 						}
+                        func = state.transform.getOutputFunction(this.variables, abbrevfam, abbrfall, altvar, transfall);
                         if (this.variables_real[0] === "container-title") {
                             var xfunc = function (state, Item, item) {
                                 if (Item['container-title'] && state.tmp.citeblob.has_volume) {
@@ -8207,7 +8210,7 @@ CSL.Attributes["@position"] = function (state, arg) {
     state.opt.update_mode = CSL.POSITION;
     if ("near-note" === arg) {
         var near_note_func = function (state, Item, item) {
-            if (item && item["near-note"]) {
+            if (item && item["position"] === CSL.POSITION_SUBSEQUENT && item["near-note"]) {
                 return true;
             }
             return false;
@@ -8626,17 +8629,6 @@ CSL.Transform = function (state) {
     var debug = false, abbreviations, token, fieldname, abbrev_family, opt;
     this.abbrevs = {};
     this.abbrevs["default"] = new state.sys.AbbreviationSegments();
-    function init(mytoken, myfieldname, myabbrev_family) {
-        token = mytoken;
-        fieldname = myfieldname;
-        abbrev_family = myabbrev_family;
-        opt = {
-            abbreviation_fallback: false,
-            alternative_varname: false,
-            transform_fallback: false
-        };
-    }
-    this.init = init;
     function abbreviate(state, Item, altvar, basevalue, myabbrev_family, use_field) {
         var value;
         if (!myabbrev_family) {
@@ -8705,18 +8697,6 @@ CSL.Transform = function (state) {
         }
         return ret;
     }
-    function setAbbreviationFallback(b) {
-        opt.abbreviation_fallback = b;
-    }
-    this.setAbbreviationFallback = setAbbreviationFallback;
-    function setAlternativeVariableName(s) {
-        opt.alternative_varname = s;
-    }
-    this.setAlternativeVariableName = setAlternativeVariableName;
-    function setTransformFallback(b) {
-        opt.transform_fallback = b;
-    }
-    this.setTransformFallback = setTransformFallback;
     function loadAbbreviation(jurisdiction, category, orig) {
         var pos, len;
         if (!jurisdiction) {
@@ -8724,7 +8704,7 @@ CSL.Transform = function (state) {
         }
         if (!orig) {
             if (!this.abbrevs[jurisdiction]) {
-                this.abbrevs[jurisdiction] = new state.sys..AbbreviationSegments();
+                this.abbrevs[jurisdiction] = new state.sys.AbbreviationSegments();
             }
             return jurisdiction;
         }
@@ -8775,15 +8755,9 @@ CSL.Transform = function (state) {
         }
         return false;
     }
-    function getOutputFunction(variables) {
-        var myabbrev_family, myfieldname, abbreviation_fallback, alternative_varname, transform_locale, transform_fallback, getTextSubfield;
-        myabbrev_family = abbrev_family;
-        myfieldname = fieldname;
-        var abbreviation_fallback = opt.abbreviation_fallback;
-        var alternative_varname = opt.alternative_varname;
-        var transform_fallback = opt.transform_fallback;
+    function getOutputFunction(variables, myabbrev_family, abbreviation_fallback, alternative_varname, transform_fallback) {
 		var localesets;
-        var langPrefs = CSL.LangPrefsMap[myfieldname];
+        var langPrefs = CSL.LangPrefsMap[variables[0]];
         if (!langPrefs) {
             localesets = false;
         } else {
@@ -8828,7 +8802,7 @@ CSL.Transform = function (state) {
                 }
                 return null;
             }
-            var res = getTextSubField(Item, myfieldname, slot.primary, true);
+            var res = getTextSubField(Item, variables[0], slot.primary, true);
             primary = res.name;
             if (publisherCheck(this, Item, primary, myabbrev_family)) {
                 return null;
@@ -8836,11 +8810,11 @@ CSL.Transform = function (state) {
 			secondary = false;
 			tertiary = false;
 			if (slot.secondary) {
-				res = getTextSubField(Item, myfieldname, slot.secondary, false, res.usedOrig);
+				res = getTextSubField(Item, variables[0], slot.secondary, false, res.usedOrig);
                 secondary = res.name;
 			}
 			if (slot.tertiary) {
-				res = getTextSubField(Item, myfieldname, slot.tertiary, false, res.usedOrig);
+				res = getTextSubField(Item, variables[0], slot.tertiary, false, res.usedOrig);
                 tertiary = res.name;
 			}
             if (myabbrev_family) {
@@ -11156,44 +11130,6 @@ CSL.Registry.prototype.doinserts = function (mylist) {
                     }
                 }
             }
-            if (this.state.sys.getAbbreviation) {
-                for (var field in this.state.transform.abbrevs["default"]) {
-                    switch (field) {
-                    case "place":
-                        if (Item["publisher-place"]) {
-                            this.state.transform.loadAbbreviation(Item.jurisdiction, "place", Item["publisher-place"]);
-                        } else if (Item["event-place"]) {
-                            this.state.transform.loadAbbreviation(Item.jurisdiction, "place", Item["event-place"]);
-                        }
-                        break;
-                    case "institution-part":
-                        for (var creatorVar in CSL.CREATORS) {
-                            for (var creatorList in Item[creatorVar]) {
-                                for (j = 0, jlen = creatorList.length; j < jlen; j += 1) {
-                                    if (creatorList[j].isInstitution) {
-                                        var subOrganizations = creatorList[j].literal;
-                                        if (!subOrganizations) {
-                                            subOrganizations = creatorList[j].family;
-                                        }
-                                        if (subOrganizations) {
-                                            subOrganizations = subOrganizations.split(/\s*|\s*/);
-                                            for (k = 0, klen = subOrganizations.length; k < klen; k += 1) {
-                                                this.state.transform.loadAbbreviation(Item.jurisdiction, "institution-part", subOrganizations[k]);
-                                                }
-                                            }
-                                        }
-                                    }
-                                }
-                            }
-                            break;
-                        default:
-                            if (Item[field]) {
-                                this.state.transform.loadAbbreviation(Item.jurisdiction, field, Item[field]);
-                            }
-                            break;
-                        }
-                    }
-            }
             akey = CSL.getAmbiguousCite.call(this.state, Item);
             this.akeys[akey] = true;
             newitem = {

From daf1899c72fba24a5bbbd35f8ba4cc4414e1bd38 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Mon, 12 Mar 2012 01:43:04 -0400
Subject: [PATCH 25/37] Remove unnecessary ellipsis

---
 chrome/locale/en-US/zotero/zotero.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/locale/en-US/zotero/zotero.properties b/chrome/locale/en-US/zotero/zotero.properties
index be1acc096..d634070c3 100644
--- a/chrome/locale/en-US/zotero/zotero.properties
+++ b/chrome/locale/en-US/zotero/zotero.properties
@@ -636,7 +636,7 @@ styles.deleteStyle					= Are you sure you want to delete the style "%1$S"?
 styles.deleteStyles					= Are you sure you want to delete the selected styles?
 
 sync.cancel							= Cancel Sync
-sync.openSyncPreferences			= Open Sync Preferences…
+sync.openSyncPreferences			= Open Sync Preferences
 sync.resetGroupAndSync				= Reset Group and Sync
 sync.removeGroupsAndSync			= Remove Groups and Sync
 sync.localObject					= Local Object

From 19a6b08b5169808f93d3de94b6c5f67461109163 Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Mon, 12 Mar 2012 06:01:50 -0500
Subject: [PATCH 26/37] Only put periods after capital latin letters

---
 chrome/content/zotero/xpcom/utilities.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index b7e7b7f75..81e72d60b 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -187,7 +187,7 @@ Zotero.Utilities = {
 			var newFirstName = '';
 			for(var i=0, n=names.length; i<n; i++) {
 				newFirstName += names[i];
-				if(names[i].length == 1) newFirstName += '.';
+				if(names[i].match(/^[A-Z]$/)) newFirstName += '.';
 				newFirstName += ' ';
 			}
 			firstName = newFirstName.trim();

From ba8bf4910f3ed1c17176dabcce0ef3ba80d0b45a Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Mon, 12 Mar 2012 16:25:35 -0400
Subject: [PATCH 27/37] Some tweaks to auto/idle-syncing

- Don't run idle sync if manual sync is required or Zotero is locked
- Don't clear sync error icon when opening pane
- Better debug message on pane open for syncing not being enabled
---
 chrome/content/zotero/xpcom/sync.js | 12 ++++++++++++
 chrome/content/zotero/zoteroPane.js | 12 ++++++------
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/chrome/content/zotero/xpcom/sync.js b/chrome/content/zotero/xpcom/sync.js
index 9dce984c7..8221f981f 100644
--- a/chrome/content/zotero/xpcom/sync.js
+++ b/chrome/content/zotero/xpcom/sync.js
@@ -1057,7 +1057,19 @@ Zotero.Sync.Runner.IdleListener = {
 			return;
 		}
 		
+		// TODO: move to Runner.sync()?
+		if (Zotero.locked) {
+			Zotero.debug('Zotero is locked -- skipping idle sync', 4);
+			return;
+		}
+		
+		if (Zotero.Sync.Server.manualSyncRequired) {
+			Zotero.debug('Manual sync required -- skipping idle sync', 4);
+			return;
+		}
+		
 		Zotero.debug("Beginning idle sync");
+		
 		Zotero.Sync.Runner.sync(true);
 		Zotero.Sync.Runner.setSyncTimeout(this._idleTimeout, true);
 	},
diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js
index 343998364..c2ee3f936 100644
--- a/chrome/content/zotero/zoteroPane.js
+++ b/chrome/content/zotero/zoteroPane.js
@@ -411,9 +411,12 @@ var ZoteroPane = new function()
 		// Auto-sync on pane open
 		if (Zotero.Prefs.get('sync.autoSync')) {
 			setTimeout(function () {
-				if (!Zotero.Sync.Server.enabled
-						|| Zotero.Sync.Server.syncInProgress
-						|| Zotero.Sync.Storage.syncInProgress) {
+				if (!Zotero.Sync.Server.enabled) {
+					Zotero.debug('Sync not enabled -- skipping auto-sync', 4);
+					return;
+				}
+				
+				if (Zotero.Sync.Server.syncInProgress || Zotero.Sync.Storage.syncInProgress) {
 					Zotero.debug('Sync already running -- skipping auto-sync', 4);
 					return;
 				}
@@ -433,9 +436,6 @@ var ZoteroPane = new function()
 		if (Zotero.Sync.Server.syncInProgress || Zotero.Sync.Storage.syncInProgress) {
 			Zotero.Sync.Runner.setSyncIcon('animate');
 		}
-		else {
-			Zotero.Sync.Runner.setSyncIcon();
-		}
 		
 		return true;
 	}

From 603e07d21af1f93268f22d0fd0f0e44af3b54ee7 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Mon, 12 Mar 2012 17:30:09 -0400
Subject: [PATCH 28/37] Translators should always run in browser when called by
 a parent translator

---
 chrome/content/zotero/xpcom/translation/translate.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/translation/translate.js b/chrome/content/zotero/xpcom/translation/translate.js
index 28ab273cd..35e673d43 100644
--- a/chrome/content/zotero/xpcom/translation/translate.js
+++ b/chrome/content/zotero/xpcom/translation/translate.js
@@ -1461,7 +1461,8 @@ Zotero.Translate.Web.prototype.translate = function(libraryID, saveAttachments,
  * Overload _translateTranslatorLoaded to send an RPC call if necessary
  */
 Zotero.Translate.Web.prototype._translateTranslatorLoaded = function() {
-	if(this.translator[0].runMode === Zotero.Translator.RUN_MODE_IN_BROWSER) {
+	if(this.translator[0].runMode === Zotero.Translator.RUN_MODE_IN_BROWSER
+			|| this._parentTranslator) {
 		// begin process to run translator in browser
 		Zotero.Translate.Base.prototype._translateTranslatorLoaded.apply(this);
 	} else {

From 5be84a5d59e9bc0b206e5520530445d0cfc5c94e Mon Sep 17 00:00:00 2001
From: aurimasv <aurimas.dev@gmail.com>
Date: Mon, 12 Mar 2012 20:33:59 -0500
Subject: [PATCH 29/37] add maxLevels to varDump to avoid infinite loops

---
 chrome/content/zotero/xpcom/utilities.js | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js
index 81e72d60b..bdf52ace7 100644
--- a/chrome/content/zotero/xpcom/utilities.js
+++ b/chrome/content/zotero/xpcom/utilities.js
@@ -1014,17 +1014,25 @@ Zotero.Utilities = {
 	 *
 	 * Adapted from http://binnyva.blogspot.com/2005/10/dump-function-javascript-equivalent-of.html
 	 */
-	"varDump":function(arr,level) {
+	"varDump":function(arr,level,maxLevel) {
 		var dumped_text = "";
 		if (!level){
 			level = 0;
 		}
+
+		if (!maxLevel) {
+			maxLevel = 4;
+		}
 		
 		// The padding given at the beginning of the line.
 		var level_padding = "";
 		for (var j=0;j<level+1;j++){
 			level_padding += "    ";
 		}
+
+		if (level > maxLevel){
+			return dumped_text + level_padding + "...\n";
+		}
 		
 		if (typeof(arr) == 'object') { // Array/Hashes/Objects
 			for (var item in arr) {
@@ -1032,7 +1040,7 @@ Zotero.Utilities = {
 				
 				if (typeof(value) == 'object') { // If it is an array,
 					dumped_text += level_padding + "'" + item + "' ...\n";
-					dumped_text += arguments.callee(value,level+1);
+					dumped_text += arguments.callee(value,level+1,maxLevel);
 				}
 				else {
 					if (typeof value == 'function'){

From 64c8f04644d921d229069c16e37458d2e0b9afe7 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Mon, 12 Mar 2012 21:38:04 -0400
Subject: [PATCH 30/37] Deal with item.tags missing a sort method

---
 chrome/content/zotero/tools/testTranslators/translatorTester.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/tools/testTranslators/translatorTester.js b/chrome/content/zotero/tools/testTranslators/translatorTester.js
index 1a05d837b..909637898 100644
--- a/chrome/content/zotero/tools/testTranslators/translatorTester.js
+++ b/chrome/content/zotero/tools/testTranslators/translatorTester.js
@@ -245,7 +245,7 @@ Zotero_TranslatorTester._sanitizeItem = function(item, forSave) {
 	if("accessDate" in item) delete item.accessDate;
 
 	//sort tags, if they're still there
-	if(item.tags) item.tags.sort();
+	if(item.tags && typeof item.tags === "object" && "sort" in item.tags) item.tags.sort();
 	
 	return item;
 };

From bb0e894c27cb7c2d31bb916fc7a236f0d749b78b Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Mon, 12 Mar 2012 22:19:04 -0400
Subject: [PATCH 31/37] Remove extra debug lines when emptying trash

---
 chrome/content/zotero/xpcom/data/items.js | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/chrome/content/zotero/xpcom/data/items.js b/chrome/content/zotero/xpcom/data/items.js
index 58b38e297..cca97c184 100644
--- a/chrome/content/zotero/xpcom/data/items.js
+++ b/chrome/content/zotero/xpcom/data/items.js
@@ -493,6 +493,8 @@ Zotero.Items = new function() {
 	 * @param	{Integer}	days	Only delete items deleted more than this many days ago
 	 */
 	this.emptyTrash = function (libraryID, days, limit) {
+		var t = new Date();
+		
 		Zotero.DB.beginTransaction();
 		var deletedIDs = this.getDeleted(libraryID, true, days);
 		if (deletedIDs.length) {
@@ -503,6 +505,11 @@ Zotero.Items = new function() {
 			Zotero.Notifier.trigger('refresh', 'trash', libraryID ? libraryID : 0);
 		}
 		Zotero.DB.commitTransaction();
+		
+		if (deletedIDs.length) {
+			Zotero.debug("Emptied " + deletedIDs.length + " item(s) from trash in " + (new Date() - t) + " ms");
+		}
+		
 		return deletedIDs.length;
 	}
 	
@@ -521,19 +528,13 @@ Zotero.Items = new function() {
 					
 					// TODO: empty group trashes if permissions
 					
-					var d = new Date();
-					
 					// Delete a few items a time
 					//
 					// TODO: increase number after dealing with slow
 					// tag.getLinkedItems() call during deletes
-					Zotero.debug("Auto-emptying items from trash");
 					var num = 10;
 					var deleted = Zotero.Items.emptyTrash(null, days, num);
 					
-					var d2 = new Date();
-					Zotero.debug("Emptied " + deleted + " old items from trash in " + (d2 - d) + " ms");
-					
 					if (!deleted) {
 						_emptyTrashTimer = null;
 						return;

From cd7d2e9975c116972a37773359de96650777887a Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Mon, 12 Mar 2012 23:57:58 -0400
Subject: [PATCH 32/37] Don't allow _itemDone to throw

---
 chrome/content/zotero/xpcom/translation/translate.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/translation/translate.js b/chrome/content/zotero/xpcom/translation/translate.js
index 35e673d43..2adb783a0 100644
--- a/chrome/content/zotero/xpcom/translation/translate.js
+++ b/chrome/content/zotero/xpcom/translation/translate.js
@@ -548,7 +548,8 @@ Zotero.Translate.Sandbox = {
 			}
 			
 			if(!item.title) {
-				throw new Error("No title specified for item");
+				translate.complete(false, new Error("No title specified for item"));
+				return;
 			}
 			
 			// create short title

From 56cba8c709006e5ebf0294aaa2a9a97a3bb06765 Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Tue, 13 Mar 2012 10:13:19 -0400
Subject: [PATCH 33/37] Don't fail on null importRegexp

---
 chrome/content/zotero/xpcom/translation/translator.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/translation/translator.js b/chrome/content/zotero/xpcom/translation/translator.js
index a398140b5..73ee6a3a3 100644
--- a/chrome/content/zotero/xpcom/translation/translator.js
+++ b/chrome/content/zotero/xpcom/translation/translator.js
@@ -283,7 +283,7 @@ Zotero.Translators = new function() {
 		var tier2Translators = [];
 		
 		for(var i=0; i<allTranslators.length; i++) {
-			if(allTranslators[i].importRegexp.test(location)) {
+			if(allTranslators[i].importRegexp && allTranslators[i].importRegexp.test(location)) {
 				tier1Translators.push(allTranslators[i]);
 			} else {
 				tier2Translators.push(allTranslators[i]);

From 954c2f6de0670bb10ca3f55d08ce81a262bb9a56 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Sat, 17 Mar 2012 03:12:49 -0400
Subject: [PATCH 34/37] Fix for manual new item not going into collection

Broken by 0d34e34a (since 3.0.3)
---
 chrome/content/zotero/zoteroPane.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js
index c2ee3f936..70bcc4688 100644
--- a/chrome/content/zotero/zoteroPane.js
+++ b/chrome/content/zotero/zoteroPane.js
@@ -662,10 +662,10 @@ var ZoteroPane = new function()
 			return false;
 		}
 		
-		// Make sure currently selected view is editable
-		if (row === undefined && this.collectionsView.selection) {
+		if ((row === undefined || row === null) && this.collectionsView.selection) {
 			row = this.collectionsView.selection.currentIndex;
 			
+			// Make sure currently selected view is editable
 			if (!this.canEdit(row)) {
 				this.displayCannotEditLibraryMessage();
 				return;

From c1a35eb134a66dc6f44dcdb293e69327139e5bb6 Mon Sep 17 00:00:00 2001
From: Frank <biercenator@gmail.com>
Date: Sat, 17 Mar 2012 12:44:02 +0800
Subject: [PATCH 35/37] Upgrade citeproc-js to version 1.0.301

---
 chrome/content/zotero/xpcom/citeproc.js | 111 ++++++++++++++----------
 1 file changed, 65 insertions(+), 46 deletions(-)

diff --git a/chrome/content/zotero/xpcom/citeproc.js b/chrome/content/zotero/xpcom/citeproc.js
index 64c80f734..cd48720a1 100644
--- a/chrome/content/zotero/xpcom/citeproc.js
+++ b/chrome/content/zotero/xpcom/citeproc.js
@@ -126,7 +126,7 @@ var CSL = {
     MARK_TRAILING_NAMES: true,
     POSITION_TEST_VARS: ["position", "first-reference-note-number", "near-note"],
     AREAS: ["citation", "citation_sort", "bibliography", "bibliography_sort"],
-    MULTI_FIELDS: ["event", "publisher", "publisher-place", "event-place", "title", "container-title", "collection-title", "authority","edition","genre","title-short","subjurisdiction","medium"],
+    MULTI_FIELDS: ["event", "publisher", "publisher-place", "event-place", "title", "container-title", "collection-title", "authority","edition","genre","title-short","medium","jurisdiction"],
     CITE_FIELDS: ["first-reference-note-number", "locator", "locator-revision"],
     MINIMAL_NAME_FIELDS: ["literal", "family"],
     SWAPPING_PUNCTUATION: [".", "!", "?", ":",","],
@@ -1061,9 +1061,6 @@ CSL.Output.Queue.prototype.append = function (str, tokname, notSerious, ignorePr
         curr = this.current.value();
     }
     if ("string" === typeof blob.blobs) {
-        if (this.state.tmp.strip_periods && !noStripPeriods) {
-            blob.blobs = blob.blobs.replace(/\./g, "");
-        }
         if (!ignorePredecessor) {
             this.state.tmp.term_predecessor = true;
         }
@@ -1076,6 +1073,9 @@ CSL.Output.Queue.prototype.append = function (str, tokname, notSerious, ignorePr
         if (blob.strings["text-case"]) {
             blob.blobs = CSL.Output.Formatters[blob.strings["text-case"]](this.state, str);
         }
+        if (this.state.tmp.strip_periods && !noStripPeriods) {
+            blob.blobs = blob.blobs.replace(/\./g, "");
+        }
         this.state.fun.flipflopper.init(str, blob);
         this.state.fun.flipflopper.processTags();
     } else if (useblob) {
@@ -1276,6 +1276,9 @@ CSL.Output.Queue.prototype.renderBlobs = function (blobs, delim, has_more) {
             if (blob.strings["text-case"]) {
                 str = CSL.Output.Formatters[blob.strings["text-case"]](this.state, str);
             }
+            if (str && this.state.tmp.strip_periods && !noStripPeriods) {
+                str = str.replace(/\./g, "");
+            }
             if (!state.tmp.suppress_decorations) {
                 llen = blob.decorations.length;
                 for (ppos = 0; ppos < llen; ppos += 1) {
@@ -2153,7 +2156,7 @@ CSL.DateParser = function () {
 };
 CSL.Engine = function (sys, style, lang, forceLang) {
     var attrs, langspec, localexml, locale;
-    this.processor_version = "1.0.298";
+    this.processor_version = "1.0.301";
     this.csl_version = "1.0";
     this.sys = sys;
     this.sys.xml = new CSL.System.Xml.Parsing();
@@ -2473,6 +2476,14 @@ CSL.Engine.prototype.retrieveItem = function (id) {
         Item.volume = Item.number;
         Item.number = undefined;
     }
+    if (Item.page) {
+        Item["page-first"] = Item.page;
+        var num = "" + Item.page;
+        m = num.split(/\s*(?:&|,|-)\s*/);
+        if (m[0].slice(-1) !== "\\") {
+            Item["page-first"] = m[0];
+        }
+    }
     if (this.opt.development_extensions.field_hack && Item.note) {
         m = Item.note.match(CSL.NOTE_FIELDS_REGEXP);
         if (m) {
@@ -2498,12 +2509,6 @@ CSL.Engine.prototype.retrieveItem = function (id) {
             }
         }
     }
-    if (this.opt.development_extensions.jurisdiction_subfield && Item.jurisdiction) {
-        var subjurisdictions = Item.jurisdiction.split(";");
-        if (subjurisdictions.length > 1) {
-            Item.subjurisdiction = subjurisdictions.join(";");
-        }
-    }
     for (var i = 1, ilen = CSL.DATE_VARIABLES.length; i < ilen; i += 1) {
         var dateobj = Item[CSL.DATE_VARIABLES[i]];
         if (dateobj) {
@@ -4720,7 +4725,11 @@ CSL.Node.group = {
                 if (state.tmp.group_context.mystack.length) {
                     state.output.current.value().parent = state.tmp.group_context.value()[4];
                 }
-                state.tmp.group_context.push([false, false, false, false, state.output.current.value()], CSL.LITERAL);
+                var label_form = state.tmp.group_context.value()[5];
+                if (this.strings.label_form_override) {
+                    label_form = this.strings.label_form_override;
+                }
+                state.tmp.group_context.push([false, false, false, false, state.output.current.value(), label_form], CSL.LITERAL);
                 if (this.strings.oops) {
                     state.tmp.group_context.value()[3] = this.strings.oops;
                 }
@@ -6853,7 +6862,11 @@ CSL.evaluateStringPluralism = function (str) {
     return 0;
 };
 CSL.castLabel = function (state, node, term, plural, mode) {
-    var ret = state.getTerm(term, node.strings.form, plural, false, mode);
+    var label_form = node.strings.form;
+    if (state.tmp.group_context.value()[5]) {
+        label_form = state.tmp.group_context.value()[5];
+    }
+    var ret = state.getTerm(term, label_form, plural, false, mode);
     if (state.tmp.strip_periods) {
         ret = ret.replace(/\./g, "");
     } else {
@@ -7285,9 +7298,6 @@ CSL.Node.number = {
             varname = this.variables[0];
             state.parallel.StartVariable(this.variables[0]);
             state.parallel.AppendToVariable(Item[this.variables[0]]);
-            if (varname === "page-range" || varname === "page-first") {
-                varname = "page";
-            }
             var node = this;
             if (!state.tmp.shadow_numbers[varname] 
                 || (state.tmp.shadow_numbers[varname].values.length 
@@ -7567,14 +7577,9 @@ CSL.Node.text = {
                         } else if (this.variables_real[0] === "page-first") {
                             func = function (state, Item) {
                                 var idx, value;
-                                value = state.getVariable(Item, "page", form);
+                                value = state.getVariable(Item, "page-first", form);
                                 if (value) {
-                                    value = ""+value;
-                                    value = value.replace("\u2013", "-", "g");
-                                    idx = value.indexOf("-");
-                                    if (idx > -1) {
-                                        value = value.slice(0, idx);
-                                    }
+                                    value = value.replace("\\", "");
                                     state.output.append(value, this, false, false, true);
                                 }
                             };
@@ -7691,9 +7696,30 @@ CSL.Node.text = {
     }
 };
 CSL.Attributes = {};
+CSL.Attributes["@subjurisdictions"] = function (state, arg) {
+    var trysubjurisdictions = parseInt(arg, 10);
+    var func = function (state, Item, item) {
+        var subjurisdictions = 0;
+        if (Item.jurisdiction) {
+            var subjurisdictions = Item.jurisdiction.split(";").length;
+        }
+        if (subjurisdictions) {
+            subjurisdictions += -1;
+        }
+        var ret = false;
+        if (subjurisdictions >= trysubjurisdictions) {
+            ret = true;
+        }
+        return [ret];
+    };
+    this.tests.push(func);
+}
+CSL.Attributes["@label-form"] = function (state, arg) {
+    this.strings.label_form_override = arg;
+}
 CSL.Attributes["@has-year-only"] = function (state, arg) {
-    trydates = arg.split(/\s+/);
-    func = function (state, Item, item) {
+    var trydates = arg.split(/\s+/);
+    var func = function (state, Item, item) {
         var ret = [];
         for (var i = 0, ilen = trydates.length; i < ilen; i += 1) {
             var trydate = Item[trydates[i]];
@@ -7708,8 +7734,8 @@ CSL.Attributes["@has-year-only"] = function (state, arg) {
     this.tests.push(func);
 }
 CSL.Attributes["@has-month-or-season-only"] = function (state, arg) {
-    trydates = arg.split(/\s+/);
-    func = function (state, Item, item) {
+    var trydates = arg.split(/\s+/);
+    var func = function (state, Item, item) {
         var ret = [];
         for (var i = 0, ilen = trydates.length; i < ilen; i += 1) {
             var trydate = Item[trydates[i]];
@@ -7724,8 +7750,8 @@ CSL.Attributes["@has-month-or-season-only"] = function (state, arg) {
     this.tests.push(func);
 }
 CSL.Attributes["@has-day-only"] = function (state, arg) {
-    trydates = arg.split(/\s+/);
-    func = function (state, Item, item) {
+    var trydates = arg.split(/\s+/);
+    var func = function (state, Item, item) {
         var ret = [];
         for (var i = 0, ilen = trydates.length; i < ilen; i += 1) {
             var trydate = Item[trydates[i]];
@@ -7849,9 +7875,6 @@ CSL.Attributes["@variable"] = function (state, arg) {
             len = this.variables.length;
             for (pos = 0; pos < len; pos += 1) {
                 variable = this.variables[pos];
-                if (variable === "page-first") {
-                    variable = "page";
-                }
                 if (variable === "authority"
                     && "string" === typeof Item[variable]
                     && "names" === this.name) {
@@ -8407,7 +8430,9 @@ CSL.Attributes["@text-case"] = function (state, arg) {
         if (arg === "title") {
             var m = false;
             var default_locale = state.opt["default-locale"][0].slice(0, 2);
-            if (Item.language) {
+            if (Item.jurisdiction) {
+                this.strings["text-case"] = "passthrough";
+            } else if (Item.language) {
                 m = Item.language.match(/^\s*([A-Za-z]{2})(?:$|-| )/);
                 if (!m) {
                     this.strings["text-case"] = "passthrough";
@@ -8634,7 +8659,7 @@ CSL.Transform = function (state) {
         if (!myabbrev_family) {
             return basevalue;
         }
-        if (["publisher-place", "event-place", "subjurisdiction"].indexOf(myabbrev_family) > -1) {
+        if (["publisher-place", "event-place", "jurisdiction"].indexOf(myabbrev_family) > -1) {
             myabbrev_family = "place";
         }
         if (["publisher", "authority"].indexOf(myabbrev_family) > -1) {
@@ -8820,11 +8845,14 @@ CSL.Transform = function (state) {
             if (myabbrev_family) {
                 primary = abbreviate(state, Item, alternative_varname, primary, myabbrev_family, true);
                 if (primary) {
-                    var m = primary.match(/^!([-_a-z]+)<<</);
+                    var m = primary.match(/^!([-,_a-z]+)<<</);
                     if (m) {
+                        var fields = m[1].split(",");
                         primary = primary.slice(m[0].length);
-                        if (state.tmp.done_vars.indexOf(m[1]) === -1) {
-                            state.tmp.done_vars.push(m[1]);
+                        for (var i = 0, ilen = fields.length; i < ilen; i += 1) {
+                            if (state.tmp.done_vars.indexOf(fields[i]) === -1) {
+                                state.tmp.done_vars.push(fields[i]);
+                            }
                         }
                     }
                 }
@@ -10075,15 +10103,6 @@ CSL.Engine.prototype.processNumber = function (node, ItemObject, variable) {
         if (num.indexOf("&") > -1 || num.indexOf("--") > -1) {
             this.tmp.shadow_numbers[variable].plural = 1;
         }
-        if (this.variable === "page-first") {
-            m = num.split(/\s*(?:&|,|-)\s*/);
-            if (m) {
-                num = m[0];
-                if (num.match(/[0-9]/)) {
-                    this.tmp.shadow_numbers[variable].numeric = true;
-                }
-            }
-        }
         var lst = num.split(/(?:,\s+|\s*\\*[\-\u2013]+\s*|\s*&\s*)/);
         var m = num.match(/(,\s+|\s*\\*[\-\u2013]+\s*|\s*&\s*)/g);
         var elements = [];

From 32ce4e04bc8cd738b10ce47dc8ca92c5ab990450 Mon Sep 17 00:00:00 2001
From: Frank <biercenator@gmail.com>
Date: Sun, 18 Mar 2012 06:22:33 +0800
Subject: [PATCH 36/37] Upgrade citeproc-js to version 1.0.302

---
 chrome/content/zotero/xpcom/citeproc.js | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/chrome/content/zotero/xpcom/citeproc.js b/chrome/content/zotero/xpcom/citeproc.js
index cd48720a1..98a361602 100644
--- a/chrome/content/zotero/xpcom/citeproc.js
+++ b/chrome/content/zotero/xpcom/citeproc.js
@@ -2156,7 +2156,7 @@ CSL.DateParser = function () {
 };
 CSL.Engine = function (sys, style, lang, forceLang) {
     var attrs, langspec, localexml, locale;
-    this.processor_version = "1.0.301";
+    this.processor_version = "1.0.302";
     this.csl_version = "1.0";
     this.sys = sys;
     this.sys.xml = new CSL.System.Xml.Parsing();
@@ -3518,10 +3518,10 @@ CSL.Engine.prototype.processCitationCluster = function (citation, citationsPre,
                     } else {
                         var ibidme = false;
                         var suprame = false;
-                        if (j > 0 && parseInt(k, 10) === 0) {
+                        if (j > 0 && parseInt(k, 10) === 0 && citations[j - 1].properties.noteIndex !== citations[j].properties.noteIndex) {
                             var items = citations[(j - 1)].sortedItems;
                             var useme = false;
-                            if ((citations[(j - 1)].sortedItems[0][1].id  == item[1].id && citations[j - 1].properties.noteIndex >= (citations[j].properties.noteIndex - 1)) || citations[(j - 1)].sortedItems[0][1].id == this.registry.registry[item[1].id].parallel) {
+                            if ((citations[j - 1].sortedItems[0][1].id  == item[1].id && citations[j - 1].properties.noteIndex >= (citations[j].properties.noteIndex - 1)) || citations[j - 1].sortedItems[0][1].id == this.registry.registry[item[1].id].parallel) {
                                 if (citationsInNote[citations[j - 1].properties.noteIndex] == 1 || citations[j - 1].properties.noteIndex == 0) {
                                     useme = true;
                                 }
@@ -3537,7 +3537,11 @@ CSL.Engine.prototype.processCitationCluster = function (citation, citationsPre,
                             } else {
                                 suprame = true;
                             }
-                        } else if (k > 0 && onecitation.sortedItems[(k - 1)][1].id == item[1].id) {
+                        } else if (k > 0 && onecitation.sortedItems[k - 1][1].id == item[1].id) {
+                            ibidme = true;
+                        } else if (k == 0 && citations[j - 1].properties.noteIndex == citations[j].properties.noteIndex
+                                   && citations[j - 1].sortedItems.length 
+                                   && citations[j - 1].sortedItems.slice(-1)[0][1].id == item[1].id) {
                             ibidme = true;
                         } else {
                             suprame = true;

From 449e90f36bcece55c54c2d520a2df3c2c07edabb Mon Sep 17 00:00:00 2001
From: Simon Kornblith <simon@simonster.com>
Date: Sun, 18 Mar 2012 17:26:40 -0400
Subject: [PATCH 37/37] Session-based auth for bookmarklet, part 1

---
 chrome/content/zotero/xpcom/connector/translate_item.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chrome/content/zotero/xpcom/connector/translate_item.js b/chrome/content/zotero/xpcom/connector/translate_item.js
index e24c65caa..e47c42694 100644
--- a/chrome/content/zotero/xpcom/connector/translate_item.js
+++ b/chrome/content/zotero/xpcom/connector/translate_item.js
@@ -72,7 +72,7 @@ Zotero.Translate.ItemSaver.prototype = {
 			newItems.push(Zotero.Utilities.itemToServerJSON(items[i]));
 		}
 		
-		var url = 'users/%%USERID%%/items?key=%%APIKEY%%';
+		var url = 'users/%%USERID%%/items';
 		var payload = JSON.stringify({"items":newItems}, null, "\t")
 		
 		Zotero.OAuth.doAuthenticatedPost(url, payload, function(status) {