suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix sorting of tag autocomplete in advanced search

Browse Source
This commit is contained in:
Dan Stillman 2015-02-25 23:58:54 -05:00
parent 9259bfd49a
commit 94b2865149
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
components/zotero-autocomplete.js
View File

@ -84,18 +84,8 @@ ZoteroAutoComplete.prototype.startSearch = function(searchString, searchParams,
+ "SELECT tagID FROM itemTags WHERE itemID = ?))"; + "SELECT tagID FROM itemTags WHERE itemID = ?))";
sqlParams.push(searchParams.itemID); sqlParams.push(searchParams.itemID);
} }
sql += " ORDER BY val COLLATE locale";
statement = this._zotero.DB.getStatement(sql, sqlParams); statement = this._zotero.DB.getStatement(sql, sqlParams);
var resultsCallback = function (results) {
if (!results) {
return;
}
var collation = self._zotero.getLocaleCollation();
results.sort(function(a, b) {
return collation.compareString(1, a.val, b.val);
});
}
break; break;
case 'creator': case 'creator':
@ -246,13 +236,6 @@ ZoteroAutoComplete.prototype.startSearch = function(searchString, searchParams,
} }
} }
if (resultsCallback) {
if (comments.length) {
throw ("Cannot sort results with comments in ZoteroAutoComplete.startSearch()");
}
resultsCallback(results);
}
self.updateResults(results, comments, true); self.updateResults(results, comments, true);
}, },