From a1a85911d8bee57d161453fa440aabc4b12176a8 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Sat, 8 Aug 2009 17:54:40 +0000 Subject: [PATCH] Double-click on parent didn't open PDF child attachment according to hierarchy if PDF was a file attachment rather than a web attachment --- chrome/content/zotero/xpcom/data/item.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chrome/content/zotero/xpcom/data/item.js b/chrome/content/zotero/xpcom/data/item.js index 98c51833f..3313c7546 100644 --- a/chrome/content/zotero/xpcom/data/item.js +++ b/chrome/content/zotero/xpcom/data/item.js @@ -3057,14 +3057,14 @@ Zotero.Item.prototype.getBestSnapshot = function() { } var url = this.getField('url'); - if (!url) { return false; } var sql = "SELECT IA.itemID, value FROM itemAttachments IA NATURAL JOIN items I " + "LEFT JOIN itemData ID ON (IA.itemID=ID.itemID AND fieldID=1) " - + "NATURAL JOIN itemDataValues WHERE sourceItemID=? AND linkMode NOT IN (?) " + + "LEFT JOIN itemDataValues IDV ON (ID.valueID=IDV.valueID) " + + "WHERE sourceItemID=? AND linkMode NOT IN (?) " + "AND IA.itemID NOT IN (SELECT itemID FROM deletedItems) " + "ORDER BY value=? DESC, mimeType='application/pdf' DESC, dateAdded ASC";