From b25d99c241830b93ff19037c63fe44c5e7b47602 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Tue, 6 Mar 2018 04:38:45 -0500 Subject: [PATCH] Only show Quick Copy menu option when appropriate --- .../content/zotero/standalone/standalone.js | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/standalone/standalone.js b/chrome/content/zotero/standalone/standalone.js index aa7f92014..564aa19c9 100644 --- a/chrome/content/zotero/standalone/standalone.js +++ b/chrome/content/zotero/standalone/standalone.js @@ -139,6 +139,15 @@ const ZoteroStandalone = new function() { this.updateQuickCopyOptions = function () { + var selected = false; + try { + selected = Zotero.getActiveZoteroPane() + .getSelectedItems() + .filter(item => item.isRegularItem()) + .length; + } + catch (e) {} + var format = Zotero.QuickCopy.getFormatFromURL(Zotero.QuickCopy.lastActiveURL); format = Zotero.QuickCopy.unserializeSetting(format); @@ -146,16 +155,18 @@ const ZoteroStandalone = new function() { var copyBibliography = document.getElementById('menu_copyBibliography'); var copyExport = document.getElementById('menu_copyExport'); - copyCitation.hidden = format.mode != 'bibliography'; - copyBibliography.hidden = format.mode != 'bibliography'; - copyExport.hidden = format.mode != 'export'; + copyCitation.hidden = !selected || format.mode != 'bibliography'; + copyBibliography.hidden = !selected || format.mode != 'bibliography'; + copyExport.hidden = !selected || format.mode != 'export'; if (format.mode == 'export') { try { let obj = Zotero.Translators.get(format.id); copyExport.label = Zotero.getString('quickCopy.copyAs', obj.label); } catch (e) { - Zotero.logError(e); + if (!(e instanceof Zotero.Exception.UnloadedDataException && e.dataType == 'translators')) { + Zotero.logError(e); + } copyExport.hidden = true; } }