suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Temporarily disable test for non-integer getAsync()

Browse Source
This commit is contained in:
Dan Stillman 2017-06-05 03:00:15 -04:00
parent 71d636e8fb
commit b79ecfb5fe
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
chrome/content/zotero/xpcom/data/dataObjects.js
View File

@ -174,7 +174,7 @@ Zotero.DataObjects.prototype.getAsync = Zotero.Promise.coroutine(function* (ids,
let id = ids[i]; let id = ids[i];
if (!Number.isInteger(id)) { if (!Number.isInteger(id)) {
// TEMP // TEMP: Re-enable test when removed
Zotero.logError(`${this._ZDO_object} ID '${id}' is not an integer (${typeof id})`); Zotero.logError(`${this._ZDO_object} ID '${id}' is not an integer (${typeof id})`);
id = parseInt(id); id = parseInt(id);
//throw new Error(`${this._ZDO_object} ID '${id}' is not an integer (${typeof id})`); //throw new Error(`${this._ZDO_object} ID '${id}' is not an integer (${typeof id})`);

3
test/tests/dataObjectsTest.js
View File

@ -10,7 +10,8 @@ describe("Zotero.DataObjects", function () {
}); });
describe("#getAsync()", function () { describe("#getAsync()", function () {
it("show throw if passed an invalid id", function* () { // TEMP: Currently just a warning
it.skip("show throw if passed an invalid id", function* () {
var e = yield getPromiseError(Zotero.Items.getAsync("[Object]")); var e = yield getPromiseError(Zotero.Items.getAsync("[Object]"));
assert.ok(e); assert.ok(e);
assert.include(e.message, '(string)'); assert.include(e.message, '(string)');