From bd5ef678f5040936db877d46c6c81f0fd127074c Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Mon, 18 Jan 2010 06:51:39 +0000 Subject: [PATCH] Fix recursion error shift-tabbing in metadata pane on item types with no creators --- chrome/content/zotero/bindings/itembox.xml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/chrome/content/zotero/bindings/itembox.xml b/chrome/content/zotero/bindings/itembox.xml index e86b796cc..15d7b3ecf 100644 --- a/chrome/content/zotero/bindings/itembox.xml +++ b/chrome/content/zotero/bindings/itembox.xml @@ -410,7 +410,7 @@ continue; } - // Start tabindex at 1000 after creators + // Start tabindex at 1001 after creators var tabindex = fieldIsClickable ? (i>0 ? this._tabIndexMinFields + i : 1) : 0; this._tabIndexMaxInfoFields = Math.max(this._tabIndexMaxInfoFields, tabindex); @@ -2201,11 +2201,17 @@ return false; case this._tabIndexMinCreators: - var nextIndex = 1; + var nextIndex = 1; // Title field break; case this._tabIndexMinFields: - var nextIndex = this._tabIndexMaxCreators; + // No creators + if (this._tabIndexMaxCreators == 0) { + var nextIndex = 1; // Title field + } + else { + var nextIndex = this._tabIndexMaxCreators; + } break; default: