suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix "Item already exists outside of collection" error and UI weirdness dragging child items between items

Browse Source 
(Don't bother removing an existing row for the item when creating the new one, since the old one will be removed in the fullness of time.)
This commit is contained in:
Dan Stillman 2010-01-25 08:50:47 +00:00
parent da0c883f45
commit c2fea7e4da
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
chrome/content/zotero/xpcom/itemTreeView.js
View File

@ -387,6 +387,7 @@ Zotero.ItemTreeView.prototype.notify = function(action, type, ids, extraData)
var id = item.id;
var row = this._itemRowMap[id];
// Item already exists in this view
if( row != null)
{
@ -762,21 +763,6 @@ Zotero.ItemTreeView.prototype.toggleOpenState = function(row, skipItemMapRefresh
for(var i = 0; i < newRows.length; i++)
{
// If item already exists elsewhere in the tree, we have to
// remove it -- this can happen when moving an item into a
// collection if the collection gets the modify event before
// the item
var existingRow = this._itemRowMap[newRows[i].id];
if (existingRow != null) {
/*
this._hideItem(existingRow);
this._treebox.rowCountChanged(existingRow + 1, -1);
if (existingRow < row) {
row--;
}
*/
throw ("Item already exists outside of collection in Zotero.ItemTreeView.toggleOpenRow()");
}
count++;
this._showItem(new Zotero.ItemTreeView.TreeRow(newRows[i], thisLevel + 1, false), row + i + 1); // item ref, before row
}