suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Maybe fix noteeditor test failures for real

Browse Source
This commit is contained in:
Dan Stillman 2017-04-01 14:29:45 -04:00
parent 7609ef35bc
commit c43823ad60
1 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/tests/noteeditorTest.js
View File

@ -8,20 +8,27 @@ describe("Note Editor", function () {
zp = win.ZoteroPane; zp = win.ZoteroPane;
}); });
beforeEach(function* () {
// Avoid "this._editor is undefined" error and incorrect note selection between tests,
// though there's definitely a better way to fix this
yield Zotero.Promise.delay(150);
});
after(function () { after(function () {
win.close(); win.close();
}); });
var waitForNoteEditor = Zotero.Promise.coroutine(function* (item) {
var noteEditor = win.document.getElementById('zotero-note-editor');
while (noteEditor.item != item) {
Zotero.debug("Waiting for note editor");
yield Zotero.Promise.delay(50);
noteEditor = win.document.getElementById('zotero-note-editor');
}
return new Zotero.Promise((resolve, reject) => {
noteEditor.noteField.onInit(() => resolve(noteEditor));
});
});
describe("Tags box", function () { describe("Tags box", function () {
it("should open new row for editing if no tags", function* () { it("should open new row for editing if no tags", function* () {
var note = yield createDataObject('item', { itemType: 'note' }); var note = yield createDataObject('item', { itemType: 'note', note: "A" });
var noteEditor = win.document.getElementById('zotero-note-editor'); var noteEditor = yield waitForNoteEditor(note);
var linksBox = noteEditor._id('links-box'); var linksBox = noteEditor._id('links-box');
linksBox.tagsClick(); linksBox.tagsClick();
var tagsBox = linksBox.id('tagsPopup').firstChild; var tagsBox = linksBox.id('tagsPopup').firstChild;
@ -32,8 +39,8 @@ describe("Note Editor", function () {
}); });
it("should only open one new row for editing", function* () { it("should only open one new row for editing", function* () {
var note = yield createDataObject('item', { itemType: 'note' }); var note = yield createDataObject('item', { itemType: 'note', note: "B" });
var noteEditor = win.document.getElementById('zotero-note-editor'); var noteEditor = yield waitForNoteEditor(note);
var linksBox = noteEditor._id('links-box'); var linksBox = noteEditor._id('links-box');
linksBox.tagsClick(); linksBox.tagsClick();
// Close and reopen // Close and reopen
@ -50,13 +57,14 @@ describe("Note Editor", function () {
it("should show tags in alphabetical order", function* () { it("should show tags in alphabetical order", function* () {
var note = new Zotero.Item('note'); var note = new Zotero.Item('note');
note.setNote('C');
note.addTag('B'); note.addTag('B');
yield note.saveTx(); yield note.saveTx();
note.addTag('A'); note.addTag('A');
note.addTag('C'); note.addTag('C');
yield note.saveTx(); yield note.saveTx();
var noteEditor = win.document.getElementById('zotero-note-editor'); var noteEditor = yield waitForNoteEditor(note);
var linksBox = noteEditor._id('links-box'); var linksBox = noteEditor._id('links-box');
assert.equal(linksBox.id('tags').summary, "A, B, C"); assert.equal(linksBox.id('tags').summary, "A, B, C");
}); });