suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix embedded items not showing up in the citation dialog.

Browse Source 
Regression in 2ad0dc00d, bad fix in 553d2b00. Closes #1448
This commit is contained in:
Adomas Venčkauskas 2018-03-08 10:21:45 +02:00
parent c7d05ad2f9
commit cc5c17a6e1
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
chrome/content/zotero/xpcom/cite.js
View File

@ -291,10 +291,9 @@ Zotero.Cite = {
* Get an item by ID, either by retrieving it from the library or looking for the document it
* belongs to.
* @param {String|Number|Array} id
* @param {Boolean} [getZoteroItems=false] - whether to get CSL or Zotero items for embedded items
* @return {Zotero.Item} item
*/
"getItem":function getItem(id, getZoteroItems=false) {
"getItem":function getItem(id) {
var slashIndex;
if(id instanceof Array) {
@ -303,12 +302,8 @@ Zotero.Cite = {
var sessionID = id.substr(0, slashIndex),
session = Zotero.Integration.sessions[sessionID],
item;
if(session) {
if (getZoteroItems) {
item = session.embeddedZoteroItems[id.substr(slashIndex+1)];
} else {
item = session.embeddedItems[id.substr(slashIndex+1)];
}
if (session) {
item = session.embeddedZoteroItems[id.substr(slashIndex+1)];
}
if(!item) {

2
chrome/content/zotero/xpcom/integration.js
View File

@ -1632,7 +1632,7 @@ Zotero.Integration.Session.prototype.writeDelayedCitation = Zotero.Promise.corou
Zotero.Integration.Session.prototype.getItems = function() {
return Zotero.Cite.getItem(Object.keys(this.citationsByItemID), true);
return Zotero.Cite.getItem(Object.keys(this.citationsByItemID));
}