suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use the Hash datatype in Notifier to store observers and improve debug output to display how many we have registered when trigger() is called

Browse Source
This commit is contained in:
Dan Stillman 2006-06-03 20:26:31 +00:00
parent 98f42001cc
commit d01ff389d4
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
chrome/chromeFiles/content/scholar/xpcom/notifier.js
View File

@ -1,7 +1,7 @@
Scholar.Notifier = new function(){ Scholar.Notifier = new function(){
var _observers = new Array(); var _observers = new Array();
_observers['columnTree'] = new Array(); _observers['columnTree'] = new Scholar.Hash();
_observers['itemTree'] = new Array(); _observers['itemTree'] = new Scholar.Hash();
this.registerColumnTree = registerColumnTree; this.registerColumnTree = registerColumnTree;
this.registerItemTree = registerItemTree; this.registerItemTree = registerItemTree;
@ -43,12 +43,15 @@ Scholar.Notifier = new function(){
throw('Invalid type in Notifier.trigger()'); throw('Invalid type in Notifier.trigger()');
} }
for (i in _observers[treeType]){ Scholar.debug("Notifier.trigger('" + event + "', '" + type + "', "
Scholar.debug("Calling _observers['" + treeType + "']" + (typeof ids=='Object' ? ids.join() : ids) + ") called "
+ "['" + i + "'].notify('" + event + "', " + type + "', " + "[column trees: " + _observers['columnTree'].length
+ (typeof ids=='Object' ? ids.join() : ids) + ", item trees: " + _observers['itemTree'].length + "]");
+ ")", 4);
_observers[treeType][i].notify(event, type, ids); for (i in _observers[treeType].items){
Scholar.debug("Calling notify() on " + treeType + " with hash '"
+ i + "'", 4);
_observers[treeType].get(i).notify(event, type, ids);
} }
} }
@ -66,15 +69,15 @@ Scholar.Notifier = new function(){
var hash = Scholar.randomString(len); var hash = Scholar.randomString(len);
tries--; tries--;
} }
while (_observers[type][hash]); while (_observers[type].get(hash));
Scholar.debug('Registering ' + type + " in notifier with hash '" + hash + "'", 4); Scholar.debug('Registering ' + type + " in notifier with hash '" + hash + "'", 4);
_observers[type][hash] = ref; _observers[type].set(hash, ref);
return hash; return hash;
} }
function _unregister(type, hash){ function _unregister(type, hash){
Scholar.debug("Unregistering " + type + " in notifier with hash '" + hash + "'", 4); Scholar.debug("Unregistering " + type + " in notifier with hash '" + hash + "'", 4);
delete _observers[type][hash]; _observers[type].remove(hash);
} }
} }