From d48adde7edd08bc0ac3311c5b743c080fb2e27d3 Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Tue, 1 Jul 2008 00:44:52 +0000
Subject: [PATCH] Sync error icon and tooltip display

---
 chrome/content/zotero/overlay.xul             |   2 +-
 chrome/content/zotero/xpcom/sync.js           |  57 ++++++++++++------
 .../default/zotero/arrow_rotate_error.png     | Bin 0 -> 843 bytes
 chrome/skin/default/zotero/overlay.css        |   8 ++-
 4 files changed, 47 insertions(+), 20 deletions(-)
 create mode 100644 chrome/skin/default/zotero/arrow_rotate_error.png

diff --git a/chrome/content/zotero/overlay.xul b/chrome/content/zotero/overlay.xul
index a561f041a..d43a19464 100644
--- a/chrome/content/zotero/overlay.xul
+++ b/chrome/content/zotero/overlay.xul
@@ -307,7 +307,7 @@
 					<toolbarbutton id="zotero-tb-sync" tooltip="_child"
 							oncommand="Zotero.Sync.Server.sync()">
 						<tooltip
-								onpopupshowing="this.firstChild.nextSibling.value = 'Last sync: ' + (Zotero.Sync.Server.lastLocalSyncTime ? new Date(Zotero.Sync.Server.lastLocalSyncTime * 1000).toLocaleString() : 'Not yet synced')"
+								onpopupshowing="if (Zotero.Sync.Server.lastSyncError) { this.firstChild.nextSibling.value = 'Last error: ' + Zotero.Sync.Server.lastSyncError; return; } this.firstChild.nextSibling.value = 'Last sync: ' + (Zotero.Sync.Server.lastLocalSyncTime ? new Date(Zotero.Sync.Server.lastLocalSyncTime * 1000).toLocaleString() : 'Not yet synced')"
 								noautohide="true"><!-- localize -->
 							<label value="Sync with Zotero Server"/>
 							<label id="zotero-last-sync-time"/>
diff --git a/chrome/content/zotero/xpcom/sync.js b/chrome/content/zotero/xpcom/sync.js
index 6f718c83e..e9a426577 100644
--- a/chrome/content/zotero/xpcom/sync.js
+++ b/chrome/content/zotero/xpcom/sync.js
@@ -378,8 +378,7 @@ Zotero.Sync.Server = new function () {
 	this.logout = logout;
 	this.setSyncTimeout = setSyncTimeout;
 	this.clearSyncTimeout = clearSyncTimeout;
-	this.startSyncAnimation = startSyncAnimation;
-	this.stopSyncAnimation = stopSyncAnimation;
+	this.setSyncIcon = setSyncIcon;
 	
 	this.__defineGetter__('username', function () {
 		return Zotero.Prefs.get('sync.server.username');
@@ -456,6 +455,12 @@ Zotero.Sync.Server = new function () {
 	this.__defineSetter__("lastLocalSyncTime", function (val) {
 		Zotero.DB.query("REPLACE INTO version VALUES ('lastlocalsync', ?)", { int: val });
 	});
+	this.__defineGetter__("lastSyncError", function () {
+		return _lastSyncError;
+	});
+	this.__defineSetter__("lastSyncError", function (val) {
+		_lastSyncError = val ? val : '';
+	});
 	
 	this.nextLocalSyncDate = false;
 	this.apiVersion = 1;
@@ -467,14 +472,14 @@ Zotero.Sync.Server = new function () {
 	
 	var _serverURL = ZOTERO_CONFIG.SYNC_URL;
 	
+	var _apiVersionComponent = "version=" + this.apiVersion;
 	var _maxAttempts = 3;
 	var _attempts = _maxAttempts;
 	var _syncInProgress;
-	
-	var _autoSyncTimer;
-	var _apiVersionComponent = "version=" + this.apiVersion;
 	var _sessionID;
 	var _sessionLock;
+	var _lastSyncError;
+	var _autoSyncTimer;
 	
 	
 	function init() {
@@ -537,7 +542,7 @@ Zotero.Sync.Server = new function () {
 	
 	function sync() {
 		Zotero.Sync.Server.clearSyncTimeout();
-		Zotero.Sync.Server.startSyncAnimation();
+		Zotero.Sync.Server.setSyncIcon('animate');
 		
 		if (_attempts < 0) {
 			_error('Too many attempts in Zotero.Sync.Server.sync()');
@@ -831,6 +836,8 @@ Zotero.Sync.Server = new function () {
 			_error('No session available in Zotero.Sync.Server.unlock()');
 		}
 		
+		var syncInProgress = _syncInProgress;
+		
 		var url = _serverURL + "unlock";
 		var body = _apiVersionComponent
 					+ '&' + Zotero.Sync.Server.sessionIDComponent;
@@ -856,7 +863,11 @@ Zotero.Sync.Server = new function () {
 				callback();
 			}
 			
-			Zotero.Sync.Server.stopSyncAnimation();
+			// Reset sync icon and last error
+			if (syncInProgress) {
+				Zotero.Sync.Server.lastSyncError = '';
+				Zotero.Sync.Server.setSyncIcon();
+			}
 		});
 	}
 	
@@ -1021,19 +1032,23 @@ Zotero.Sync.Server = new function () {
 	}
 	
 	
-	function startSyncAnimation() {
+	function setSyncIcon(status) {
+		status = status ? status : '';
+		
+		switch (status) {
+			case '':
+			case 'animate':
+			case 'error':
+				break;
+			
+		default:
+			throw ("Invalid sync icon status '" + status + "' in Zotero.Sync.Server.setSyncIcon()");
+		}
+		
 		var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
 			.getService(Components.interfaces.nsIWindowMediator);
 		var win = wm.getMostRecentWindow('navigator:browser');
-		win.document.getElementById('zotero-tb-sync').setAttribute('animate', 'true');
-	}
-	
-	
-	function stopSyncAnimation() {
-		var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
-			.getService(Components.interfaces.nsIWindowMediator);
-		var win = wm.getMostRecentWindow('navigator:browser');
-		win.document.getElementById('zotero-tb-sync').removeAttribute('animate');
+		win.document.getElementById('zotero-tb-sync').setAttribute('status', status);
 	}
 	
 	
@@ -1075,8 +1090,14 @@ Zotero.Sync.Server = new function () {
 			Zotero.Sync.Server.unlock()
 		}
 		
-		Zotero.Sync.Server.stopSyncAnimation();
+		Zotero.Sync.Server.setSyncIcon('error');
 		
+		if (e.name) {
+			Zotero.Sync.Server.lastSyncError = e.name;
+		}
+		else {
+			Zotero.Sync.Server.lastSyncError = e;
+		}
 		throw(e);
 	}
 }
diff --git a/chrome/skin/default/zotero/arrow_rotate_error.png b/chrome/skin/default/zotero/arrow_rotate_error.png
new file mode 100644
index 0000000000000000000000000000000000000000..dce1f80083beb75965b03fdbe50b5401b21c14bb
GIT binary patch
literal 843
zcmV-R1GM~!P)<h;3K|Lk000e1NJLTq000yK000yS1^@s6jfou%00001b5ch_0Itp)
z=>Px#24YJ`L;(K){{a7>y{D4^000SaNLh0L01FcU01FcV0GgZ_00007bV*G`2iOK4
z5g#jYJ>Pc#00PTNL_t(I%k7lOOVn`~#-H!|UB=0AoT(;DMaL~S%yv6SBt;ukL`BhZ
zsGy>tg$P=RJoFzFM9`r_K?|Z1deSZi9ik$Tq;<5hanyb_mCg2BzFjgRY^F=Mp6mNQ
zA6|H$_XYkdo0guL|7FS9M&F<6lnu~utcDhxYWUg5B{y?&T%VR*Sm2(jpJjp-uba&S
z^)vT#;)l4Tc|^oYN=ivdfl*^rM?z86fBA*=SHOnjwMBySwqRMXsXQ2j*P9Ox0uhHK
zj@RKgh{i@zVjB0i?deWT`ovVQ{Q5j5h3KfQtyxrEH5X|+4MhS(9K<*j7m!Lq2<~!w
zT+XlFDS_qdN{>}klrO5Ts%D%Bx!i+Sp_dr>5J72SDU_6m#-adYGjD8ePi0+-l;TKb
zStTrOLfa1RKkT(fjL7ZbrxEUoM;ta01{3hM?dvjr_f9#XP@>Z3^?@;9aClHlB`<a#
z?QI?JX%4<~RZ!5SdeUPLJ$HexS!1*Q`bv^YLJ)@}2_>Z#ivJiru)D5mn|2kfSk>he
z4({#T{`o-nZX+YmjHO8_`8<(Kz|jtZbIM2vajx~&+RK)w?v!K47~>XJ2Wr&Hf;unf
z^f4n)YiOy&rT62*@Tgqms%co$*dm%|6&>*vFZUV)9WVykF{8K%fzKiBCVe#{u;)ad
z?Jvu_7X38xXlQ&0oH%CNF)S`z0^;8Q$AFVIKomx!zg{04?0=GV%QrW6TGB1IgvQ@K
z36BjpmF7p}7B<12c!0bDFLHctIPu5GFR3B$=_enZ_xZEl@|`{R!aH_tSiCS9>MSa1
z(N6Liv^fSdo&aMS+Wrb8`Y?Uo))poMJ2J**Qk&R*9qrj!E6B~Pgn||u;4T0h%ZBCH
zFyk6v%uUjN7{HaRKmbS?{U;OA)3Y4QhHcug(-zE$B+~H|tZylpNfUP39Q$Yg@;kMl
V0B0o*;p6}S002ovPDHLkV1j)Ld#C^a

literal 0
HcmV?d00001

diff --git a/chrome/skin/default/zotero/overlay.css b/chrome/skin/default/zotero/overlay.css
index eeaf65535..ee3b79e92 100644
--- a/chrome/skin/default/zotero/overlay.css
+++ b/chrome/skin/default/zotero/overlay.css
@@ -194,13 +194,19 @@
 #zotero-tb-sync {
 	margin-top: -2px;
 	margin-left: -2px;
+	margin-right: -2px;
 	list-style-image: url(chrome://zotero/skin/arrow_rotate_static.png);
 }
 
-#zotero-tb-sync[animate=true] {
+#zotero-tb-sync[status=animate] {
 	list-style-image: url(chrome://zotero/skin/arrow_rotate_animated.png);
 }
 
+#zotero-tb-sync[status=error] {
+	list-style-image: url(chrome://zotero/skin/arrow_rotate_error.png);
+}
+
+
 #zotero-tb-sync #zotero-last-sync-time
 {
 	color: gray;