suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Scholar_Object._loadObjectData() and _loadCreators() weren't setting the _objectDataLoaded and _creatorsLoaded flags if there were no rows, causing incessant trips to the DB

Browse Source
This commit is contained in:
Dan Stillman 2006-03-18 23:46:50 +00:00
parent 749ef47bbd
commit dc4f276297
1 changed files with 5 additions and 2 deletions

7
chrome/chromeFiles/content/scholar/data_access.js
View File

@ -219,6 +219,7 @@ Scholar_Object.prototype.removeCreator = function(orderIndex){
* Field can be passed as fieldID or fieldName * Field can be passed as fieldID or fieldName
*/ */
Scholar_Object.prototype.getField = function(field){ Scholar_Object.prototype.getField = function(field){
//Scholar.debug('Requesting field ' + field + ' for object ' + this.getID(), 4);
if (this.isPrimaryField(field)){ if (this.isPrimaryField(field)){
return this._data[field] ? this._data[field] : ''; return this._data[field] ? this._data[field] : '';
} }
@ -646,6 +647,8 @@ Scholar_Object.prototype._loadCreators = function(){
+ 'WHERE objectID=' + this.getID() + ' ORDER BY orderIndex'; + 'WHERE objectID=' + this.getID() + ' ORDER BY orderIndex';
var creators = Scholar_DB.query(sql); var creators = Scholar_DB.query(sql);
this._creatorsLoaded = true;
if (!creators){ if (!creators){
return true; return true;
} }
@ -659,7 +662,6 @@ Scholar_Object.prototype._loadCreators = function(){
this._creators.set(creators[i]['orderIndex'], creator); this._creators.set(creators[i]['orderIndex'], creator);
} }
this._creatorsLoaded = true;
return true; return true;
} }
@ -679,11 +681,12 @@ Scholar_Object.prototype._loadObjectData = function(){
var result = Scholar_DB.query(sql,[{'int':this._data['objectID']}]); var result = Scholar_DB.query(sql,[{'int':this._data['objectID']}]);
this._objectDataLoaded = true;
if (result){ if (result){
for (var i=0,len=result.length; i<len; i++){ for (var i=0,len=result.length; i<len; i++){
this.setField(result[i]['fieldID'], result[i]['value'], true); this.setField(result[i]['fieldID'], result[i]['value'], true);
} }
this._objectDataLoaded = true;
return true; return true;
} }
else { else {