From e643d85d2ca226053c00774497463dec63d92f3f Mon Sep 17 00:00:00 2001 From: Simon Kornblith Date: Tue, 27 Dec 2011 20:13:08 +0000 Subject: [PATCH] Get rid of for each --- chrome/content/zotero/xpcom/utilities.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/chrome/content/zotero/xpcom/utilities.js b/chrome/content/zotero/xpcom/utilities.js index 17bff00fa..3216ee510 100644 --- a/chrome/content/zotero/xpcom/utilities.js +++ b/chrome/content/zotero/xpcom/utilities.js @@ -1329,8 +1329,10 @@ Zotero.Utilities = { // map text fields for(var variable in CSL_TEXT_MAPPINGS) { if(variable in cslItem) { - for each(var field in CSL_TEXT_MAPPINGS[variable]) { - var fieldID = Zotero.ItemFields.getID(field); + var textMappings = CSL_TEXT_MAPPINGS[variable]; + for(var i in textMappings) { + var field = textMappings[i], + fieldID = Zotero.ItemFields.getID(field); if(Zotero.ItemFields.isBaseField(fieldID)) { var newFieldID = Zotero.ItemFields.getFieldIDFromTypeAndBase(itemTypeID, fieldID); if(newFieldID) fieldID = newFieldID; @@ -1355,8 +1357,10 @@ Zotero.Utilities = { creatorTypeID = Zotero.CreatorTypes.getPrimaryIDForType(itemTypeID); } - for each(var cslAuthor in cslItem[CSL_NAMES_MAPPINGS[field]]) { - var creator = isZoteroItem ? new Zotero.Creator() : {}; + var nameMappings = cslItem[CSL_NAMES_MAPPINGS[field]]; + for(var i in nameMappings) { + var cslAuthor = nameMappings[i], + creator = isZoteroItem ? new Zotero.Creator() : {}; if(cslAuthor.family || cslAuthor.given) { if(cslAuthor.family) creator.lastName = cslAuthor.family; if(cslAuthor.given) creator.firstName = cslAuthor.given;