suzanne.soy/zotero
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reverse argument orders to minimize calls to the getter

Browse Source
This commit is contained in:
Simon Kornblith 2011-08-19 07:26:44 +00:00
parent 701a202a5f
commit e64f5b2c83
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
chrome/content/zotero/xpcom/data/item.js
View File

@ -213,7 +213,7 @@ Zotero.Item.prototype.getField = function(field, unformatted, includeBaseMapped)
return ''; return '';
} }
if (this.id && this._itemData[fieldID] === null && !this._itemDataLoaded) { if (!this._itemDataLoaded && this.id && this._itemData[fieldID] === null) {
this._loadItemData(); this._loadItemData();
} }
@ -424,7 +424,7 @@ Zotero.Item.prototype.setType = function(itemTypeID, loadIn) {
throw ('Cannot change type in loadIn mode in Zotero.Item.setType()'); throw ('Cannot change type in loadIn mode in Zotero.Item.setType()');
} }
if (this.id && !this._itemDataLoaded) { if (!this._itemDataLoaded && this.id) {
this._loadItemData(); this._loadItemData();
} }
@ -924,7 +924,7 @@ Zotero.Item.prototype.getDisplayTitle = function (includeAuthorAndDate) {
* Returns the number of creators for this item * Returns the number of creators for this item
*/ */
Zotero.Item.prototype.numCreators = function() { Zotero.Item.prototype.numCreators = function() {
if (this.id && !this._creatorsLoaded) { if (!this._creatorsLoaded && this.id) {
this._loadCreators(); this._loadCreators();
} }
return this._creators.length; return this._creators.length;
@ -932,7 +932,7 @@ Zotero.Item.prototype.numCreators = function() {
Zotero.Item.prototype.hasCreatorAt = function(pos) { Zotero.Item.prototype.hasCreatorAt = function(pos) {
if (this.id && !this._creatorsLoaded) { if (!this._creatorsLoaded && this.id) {
this._loadCreators(); this._loadCreators();
} }
@ -946,7 +946,7 @@ Zotero.Item.prototype.hasCreatorAt = function(pos) {
* Note: Creator data array is returned by reference * Note: Creator data array is returned by reference
*/ */
Zotero.Item.prototype.getCreator = function(pos) { Zotero.Item.prototype.getCreator = function(pos) {
if (this.id && !this._creatorsLoaded) { if (!this._creatorsLoaded && this.id) {
this._loadCreators(); this._loadCreators();
} }
@ -958,7 +958,7 @@ Zotero.Item.prototype.getCreator = function(pos) {
* Return the position of the given creator, or FALSE if not found * Return the position of the given creator, or FALSE if not found
*/ */
Zotero.Item.prototype.getCreatorPosition = function(creatorID) { Zotero.Item.prototype.getCreatorPosition = function(creatorID) {
if (this.id && !this._creatorsLoaded) { if (!this._creatorsLoaded && this.id) {
this._loadCreators(); this._loadCreators();
} }
@ -978,7 +978,7 @@ Zotero.Item.prototype.getCreatorPosition = function(creatorID) {
* Note: Creator data array is returned by reference * Note: Creator data array is returned by reference
*/ */
Zotero.Item.prototype.getCreators = function() { Zotero.Item.prototype.getCreators = function() {
if (this.id && !this._creatorsLoaded) { if (!this._creatorsLoaded && this.id) {
this._loadCreators(); this._loadCreators();
} }
@ -1047,7 +1047,7 @@ Zotero.Item.prototype.setCreator = function(orderIndex, creator, creatorTypeIDOr
* Remove a creator and shift others down * Remove a creator and shift others down
*/ */
Zotero.Item.prototype.removeCreator = function(orderIndex) { Zotero.Item.prototype.removeCreator = function(orderIndex) {
if (this.id && !this._creatorsLoaded) { if (!this._creatorsLoaded && this.id) {
this._loadCreators(); this._loadCreators();
} }